bug#35668: 26.2; default value of `dired-omit-files'

bug#35668: 26.2; default value of `dired-omit-files'

[Drew Adams]

As mentioned in passing in bug #34911, I think the default value should
be this:

"\\`\\.?#\\|\\`\\.\\'\\|\\`\\.\\.\\'"

instead of this:

"^\\.?#\\|^\\.$\\|^\\.\\.$"


In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32)
 of 2019-04-13
Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749
Windowing system distributor `Microsoft Corp.', version 10.0.17134
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''

bug#35668: 26.2; default value of `dired-omit-files'

[Noam Postavsky]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

Drew Adams <drew.adams@oracle.com> writes:

> As mentioned in passing in bug #34911, I think the default value should
> be this:
>
> "\\`\\.?#\\|\\`\\.\\'\\|\\`\\.\\.\\'"
>
> instead of this:
>
> "^\\.?#\\|^\\.$\\|^\\.\\.$"

Right, I'd also escape the "." with [], because so many backslashes make
my eyes hurt.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 947 bytes --]

From 1be76f5272236d8238cf8a39ed96732478ea6e39 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Sun, 12 May 2019 12:42:35 -0400
Subject: [PATCH] Fix dired-omit-files regexp (Bug#35668)

* lisp/dired-x.el (dired-omit-files): Match beginning and of string,
rather than beginning of end of line.
---
 lisp/dired-x.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/dired-x.el b/lisp/dired-x.el
index defc541ddc..3b78ec47d9 100644
--- a/lisp/dired-x.el
+++ b/lisp/dired-x.el
@@ -159,7 +159,7 @@ (define-minor-mode dired-omit-mode
 
 (put 'dired-omit-mode 'safe-local-variable 'booleanp)
 
-(defcustom dired-omit-files "^\\.?#\\|^\\.$\\|^\\.\\.$"
+(defcustom dired-omit-files "\\`[.]?#\\|\\`[.][.]?\\'"
   "Filenames matching this regexp will not be displayed.
 This only has effect when `dired-omit-mode' is t.  See interactive function
 `dired-omit-mode' (\\[dired-omit-mode]) and variable
-- 
2.11.0

bug#35668: 26.2; default value of `dired-omit-files'

[Noam Postavsky]

tags 35668 fixed
close 35668 27.1
quit

> Subject: [PATCH] Fix dired-omit-files regexp (Bug#35668)
>
> * lisp/dired-x.el (dired-omit-files): Match beginning and of string,
> rather than beginning of end of line.

Fixed typos in message and pushed to master.

d7c8196c96 2019-05-19T10:35:51-04:00 "Fix dired-omit-files regexp (Bug#35668)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d7c8196c96fd4bb732d1336305943feb3badf27c