From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: [PATCH] Make `C-x {' and `C-x }' repeatable Date: Wed, 22 May 2013 16:53:55 -0700 (PDT) Message-ID: References: <87mwrombc3.fsf@mail.jurta.org> <87r4gyondh.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1369266864 11125 80.91.229.3 (22 May 2013 23:54:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 May 2013 23:54:24 +0000 (UTC) Cc: =?iso-8859-1?B?R2F1dGhpZXIg1nN0ZXJ2YWxs?= , emacs-devel@gnu.org To: Stefan Monnier , Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 23 01:54:23 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UfIrO-0002Mb-IZ for ged-emacs-devel@m.gmane.org; Thu, 23 May 2013 01:54:22 +0200 Original-Received: from localhost ([::1]:44143 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfIrO-0002zn-94 for ged-emacs-devel@m.gmane.org; Wed, 22 May 2013 19:54:22 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfIr7-0002i0-By for emacs-devel@gnu.org; Wed, 22 May 2013 19:54:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfIr2-0003w0-1A for emacs-devel@gnu.org; Wed, 22 May 2013 19:54:05 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:50363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfIr1-0003vu-Py for emacs-devel@gnu.org; Wed, 22 May 2013 19:53:59 -0400 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r4MNru5h028489 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 22 May 2013 23:53:57 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r4MNruLw024016 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 22 May 2013 23:53:57 GMT Original-Received: from abhmt104.oracle.com (abhmt104.oracle.com [141.146.116.56]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r4MNrtX4017685; Wed, 22 May 2013 23:53:55 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 156.151.31.81 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159738 Archived-At: > >> I want to have a repeatable command bound to a key on `isearch-mode-ma= p'. >=20 > Of course. Bug#14095 is a clear bug That's reassuring; thanks. As no one had yet had a chance to respond to the bug report, I wasn't sure that you would see it that way. > linked to the following comment in set-temporary-overlay-map: >=20 > ;; FIXME: That's the keymaps with highest precedence, except for > ;; the `keymap' text-property ;-( >=20 > the bug is actually wrong, Do you mean that comment or the bug #14095 report? > because additionally to the `keymap' > property, overriding-local-map and overriding-terminal-local-map are two > more keymaps of higher precedence. So the right fix for it is to > introduce a new keymap (call it "overriding-temporary-local-map" or > something) which is like overriding-terminal-local-map except that it > doesn't disable other keymaps (it just has higher precedence). Sounds good to me (with limited understanding). > > Maybe a better implementation would be with the help of > > `set-temporary-overlay-map'. I'll try to do this for Isearch. >=20 > Isearch might benefit from being changed to use such a new > overriding-temporary-local-map as well. It might let us drop the > isearch-other-char command (which has the drawback of putting things > back onto unread-command-event, which is inherently unreliable in the > presence of some function-key-map bindings, among other problems). > Of course, such a change might also bump into new problems. A priori, that too sounds good to me (again, with limited understanding).