From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Excessive use of `eassert` Date: Tue, 23 Jan 2024 23:45:17 -0800 Organization: UCLA Computer Science Department Message-ID: References: <83jzo5x0q8.fsf@gnu.org> <83sf2tv029.fsf@gnu.org> <811d5f03-fad4-47e1-b3fd-2f45229a5ee1@cs.ucla.edu> <1bcc2fc4-da9f-488e-b416-ef4443a3da65@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13997"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Alan Mackenzie , Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 24 08:46:18 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rSXxg-0003Qd-Rv for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Jan 2024 08:46:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSXwv-0007NF-54; Wed, 24 Jan 2024 02:45:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSXwo-0007My-TH for emacs-devel@gnu.org; Wed, 24 Jan 2024 02:45:23 -0500 Original-Received: from mail.cs.ucla.edu ([131.179.128.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSXwm-0003WZ-J0; Wed, 24 Jan 2024 02:45:22 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id E66063C00E40E; Tue, 23 Jan 2024 23:45:17 -0800 (PST) Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id XQK3bKNvQmC6; Tue, 23 Jan 2024 23:45:17 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id A8E283C005171; Tue, 23 Jan 2024 23:45:17 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu A8E283C005171 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1706082317; bh=pmh47nX7ezA/qK9SDWFXXIQQuNEJWrofhQ7tIV9hSn4=; h=Message-ID:Date:MIME-Version:To:From; b=mo20jf5nUzOBpAagZwe6/u5+e6okUY8+0jWxXUCjOZrC0uKiI09tQh/Y3a/M+WbW+ e9xY30Aur9N/YZuXXYNumm6GGFpVZq9RkN36Mn8TosEB5u4i7uuFpv1aUK1SazzezG FDXPeGK0p+nqgmQ2qf03hmM2tTrZLvJViph2BtfY+aCj+ZBqABchbUhTA1MJHlXt1k oqz3GrWKgsA9g7cc815wZb+Q3OPkcO24nYqseJPntIKv30kaApvRyMkMsTpv+M5G2I 7Dw1jh2WmdbtEJD3TDZJInDE4qGc2O5Bxm5cJkQNHI7SiiDCFly6zInqB8l0+4+wFG yo8q5Jl//Xm8g== X-Virus-Scanned: amavis at mail.cs.ucla.edu Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id Y8gb6N7_hOnQ; Tue, 23 Jan 2024 23:45:17 -0800 (PST) Original-Received: from [192.168.254.12] (unknown [47.148.192.211]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 89E1B3C00E40E; Tue, 23 Jan 2024 23:45:17 -0800 (PST) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=131.179.128.66; envelope-from=eggert@cs.ucla.edu; helo=mail.cs.ucla.edu X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315284 Archived-At: On 2024-01-23 09:11, Stefan Monnier wrote: > How 'bout the patch below. Thanks, looks good, I installed it with minor changes (notably, renamed the new make__lisp_symbol to make_lisp_symbol_internal). I occasionally compile with -O0 on an older (circa 2010) CPU. If the newly-installed code turns out to be too slow for that in some cases, we can turn builtin_lisp_symbol and make_lisp_symbol_internal into lisp_h_ macros in the same style as the existing macros. This would avoid the problem that my previous patch had with dueling implementations.