From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#23484: 25.1.50; undo doesn't work properly in xref-query-replace-in-results Date: Thu, 12 May 2016 00:11:47 +0300 Message-ID: References: <86d1owl682.fsf@yandex.ru> <87inyoxpz8.fsf@mail.linkov.net> <8760unxaoi.fsf@mail.linkov.net> <118c4316-9179-c9dd-e7d1-97b96921d922@yandex.ru> <8737pp1tt6.fsf@mail.linkov.net> <87k2j0b9sk.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1463001144 32065 80.91.229.3 (11 May 2016 21:12:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 May 2016 21:12:24 +0000 (UTC) Cc: 23484@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 11 23:12:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b0bQT-0002bw-Fz for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 May 2016 23:12:13 +0200 Original-Received: from localhost ([::1]:54157 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0bQS-0005iM-QZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 May 2016 17:12:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0bQO-0005gf-CS for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 17:12:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0bQI-0006Dq-18 for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 17:12:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0bQH-0006Dj-Ui for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 17:12:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b0bQH-0006oo-KQ for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 17:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 May 2016 21:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23484 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23484-submit@debbugs.gnu.org id=B23484.146300111826201 (code B ref 23484); Wed, 11 May 2016 21:12:01 +0000 Original-Received: (at 23484) by debbugs.gnu.org; 11 May 2016 21:11:58 +0000 Original-Received: from localhost ([127.0.0.1]:47698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0bQE-0006oW-6F for submit@debbugs.gnu.org; Wed, 11 May 2016 17:11:58 -0400 Original-Received: from mail-wm0-f65.google.com ([74.125.82.65]:33374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0bQC-0006oF-Gu for 23484@debbugs.gnu.org; Wed, 11 May 2016 17:11:56 -0400 Original-Received: by mail-wm0-f65.google.com with SMTP id r12so11952072wme.0 for <23484@debbugs.gnu.org>; Wed, 11 May 2016 14:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=2b9/YQiPkQBqcMkFI5dxQOCLOIhiW1//lID5E/0UzKE=; b=qR48Vy4Is2ejeU4ggYTq8ONwi0VbHXeS++4Js2JEQF4Og5ypW+yiEa75LD60iy0t1U xIs8QsRcEmT+TjhECLDVw6vBf+LDZASB5yPn3bjQronA4LfL4eLVCo3jFjgQvnN3bUJ3 UONsYNbpaQLsDQYeuix8ox765/2yWkI3FLMo0raUkttfxjSD/eFFlBs0XPKbtE6XP96d Og30xX0HGaw/rna1vE34l65J8HADVYcGuCUb1YUmzKid1msps+QRgCvVNr6dIr29SAwg 59sfoL73/c4uW6yN70o8gI89KSebhBWxt4J7NRIOjIJJExEEt1dy2IbHlSuzMJb8J0+a adLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=2b9/YQiPkQBqcMkFI5dxQOCLOIhiW1//lID5E/0UzKE=; b=GgQvtdPvvd9mSlWNCNr2MBQNd9UAh6SVFc7caVTc/aIh7Kcg46z/PGttRxeHx2dT9G or/uKgsUxRWqjKEr4+vA4vAedMHyDB9aQ4r5kQcD4DGvRo/a1p/yIjyGtVAchjd3zyig TifzuNEDa/xZUwjbEKoUVdrPQsDUAH59MPp3XYfEPVK9Ni5wCJdqWkxUUVwg78aURaa0 8oRBaaHNxuP+Wopj+yw6Uqjind0XosAxIg1kJ8jAdoesVkz50IsBy2BLERTZoFH+wR+H BqhnqI+YIOSstNC72XJUTtWgTb+/MR6lq/9a40zVL/MnFjYiPYF+PgyoOuP6LNGxHteV gHKQ== X-Gm-Message-State: AOPr4FVOLwzGpJtim9IcW8X/ZBmgRisiGKr3ARo2rn5a1fG6DpFDLQxQUD97ewHwWXT45w== X-Received: by 10.194.234.167 with SMTP id uf7mr5990508wjc.122.1463001110574; Wed, 11 May 2016 14:11:50 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id c194sm37832686wme.9.2016.05.11.14.11.49 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 11 May 2016 14:11:49 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1 In-Reply-To: <87k2j0b9sk.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118144 Archived-At: On 05/11/2016 11:48 PM, Juri Linkov wrote: >> You're probably right. We could provide a separate command with that >> advanced feature (or only use ask for FROM with prefix argument). We would >> still have `.*' under the covers in the default case, though. > > What is the purpose of asking FROM? If to be able to replace > a substring of the original xref search string, then anyway it's > inconvenient for the user to type a part of the already typed string > again, e.g. after searching with xref for the string “abracadabra”, > pressing ‘r’ requires typing a substring “abracadabr”, etc. See the quote above from my previous message. > More useful would be to prefill the original string in the minibuffer > (here INITIAL-CONTENTS of read-from-minibuffer is justified) > for easy editing (removing parts of the xref search string). Again: we don't have the access to the "original string", and there might not have been one. > And then why limit to only boundaries of matches? The user sees > a list of matching lines in the *xref* buffer. Let's allow the users > to replace any text within the displayed matching lines (WYSIWYG). It's not something I've ever had an urge to do, but sure, the more features the better. However, how would you allow doing this *without* losing the ability to replace the matches and just the matches? That should be the default choice.