From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history Date: Thu, 15 Dec 2022 16:08:04 +0200 Message-ID: References: <8735budxiz.fsf@gmail.com> <87k04li5nw.fsf@gmail.com> <864jvphx4r.fsf@mail.linkov.net> <86tu3mftm0.fsf@mail.linkov.net> <875yg0to11.fsf@gmail.com> <86zgdalj0h.fsf@mail.linkov.net> <86fsdpjasd.fsf@mail.linkov.net> <86k02zjiwj.fsf@mail.linkov.net> <864ju1lt5k.fsf@mail.linkov.net> <403e8284-e32c-f547-748e-371d26eedace@yandex.ru> <86cz8or02n.fsf@mail.linkov.net> <87sfhko3tf.fsf@gmail.com> <868rjbusog.fsf@mail.linkov.net> <87h6xylyox.fsf@gmail.com> <1d03758e-369a-c522-a91a-696243f1074f@yandex.ru> <87cz8ln5lt.fsf@gmail.com> <87359hlycd.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27687"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: Eli Zaretskii , 58447@debbugs.gnu.org, Juri Linkov To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 15 15:09:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5ovE-00071s-9D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Dec 2022 15:09:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5ov2-0006Xt-3s; Thu, 15 Dec 2022 09:09:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5ov0-0006Xh-CN for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 09:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5ov0-0003Os-42 for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 09:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5ouz-0006Zw-VR for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 09:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2022 14:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58447-submit@debbugs.gnu.org id=B58447.167111329425268 (code B ref 58447); Thu, 15 Dec 2022 14:09:01 +0000 Original-Received: (at 58447) by debbugs.gnu.org; 15 Dec 2022 14:08:14 +0000 Original-Received: from localhost ([127.0.0.1]:43044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ouE-0006ZU-IX for submit@debbugs.gnu.org; Thu, 15 Dec 2022 09:08:14 -0500 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:46600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ouC-0006ZO-3O for 58447@debbugs.gnu.org; Thu, 15 Dec 2022 09:08:12 -0500 Original-Received: by mail-wm1-f51.google.com with SMTP id f13-20020a1cc90d000000b003d08c4cf679so1914090wmb.5 for <58447@debbugs.gnu.org>; Thu, 15 Dec 2022 06:08:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=9PlE50BYe9wPiiYsvVCFZRukCpqEGYtRcovoAJQzM00=; b=IbSC1TtffNuL02FW0v06W6D6JPGLIFgJIlBaeKHqpYkmh1mfjZxUb+btkEQGY2Xct8 c/1zRTx9kIyo3eh0EJsm/MheProQnw4sPAbkA9XID/fcr9wKVQ7e4SZdbaJEhbYoM1wz RTeXp3D+MOTde2gND9/jIcQ9vbOsu8pJOKPB+Mj6xjWvmwh8GaMhUdNtgJ9e3yParz3D sWwL5Mt0QGQRy67PzxlbcaQDsku1htR7r6gMnon/XLv0FRRjEiDnkdZ8YmfvXA09nopk sYM0Jh/mDNSrmluweBIoai14Jt4275OOb7/OcdNRiZuE4W5Dd4o7g3IYIWdRROi58YJF 6VEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9PlE50BYe9wPiiYsvVCFZRukCpqEGYtRcovoAJQzM00=; b=d7FYjIJ7QEjqLR5yT7QLj8lp2ThnrikQQJENvuRCbhoLXsGEup2VK/fpI1ZqwyykYD MVB7guEApVQ6+5uL+06lIIjWwgGBPfvADUyGvz+qQNA/brLHS2oufmveHqlxrfIUzePg 30UgE+ofazm7KsmDxq5qzv2HwgC6SzcGlCpG58hCpSqj4ejQjE8ANthlSBwBKfcn4jgr Oh/dTkQ2OsITSpHf0a7LVA0p6PqjNB0Q+o/QEZ2JAzFw0GY9Z0QtyOl8C2jgzaPpl1A0 t2Amw5c6f2BT07tsQeo5WsqLS1/Y0UE8xRFFQ6SHAIKCLOcdqAXfJ6VCPBdLwghgv8CF pQkA== X-Gm-Message-State: ANoB5pnrD3teLB3tfDdeX9/JFMWtYaRv+XJv1e7ecBuESpaN5f2aEob0 Og94C3j6txc9fckiPKQvq2g= X-Google-Smtp-Source: AA0mqf7XD/+5TtHgRduXDCgoOqOKRIRUhUJy+1rhKMRyH2Fgu2c2ewm7Dx/eFAxoer/HgpmdoP+UHQ== X-Received: by 2002:a05:600c:1e88:b0:3d1:efa1:3689 with SMTP id be8-20020a05600c1e8800b003d1efa13689mr21604873wmb.24.1671113286165; Thu, 15 Dec 2022 06:08:06 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id n14-20020a5d4c4e000000b00236883f2f5csm5992195wrt.94.2022.12.15.06.08.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Dec 2022 06:08:05 -0800 (PST) Content-Language: en-US In-Reply-To: <87359hlycd.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251094 Archived-At: On 15/12/2022 13:07, Augusto Stoffel wrote: > On Thu, 15 Dec 2022 at 01:04, Dmitry Gutov wrote: > >> We're probably talking about the same thing, if the filtering is going >> to use the list of files from project-files, rather than >> file-exists-p. In either case, the user could actually input a >> non-existent file (or file not in the completion table) which would >> fail that test. But they'll hopefully hit C-x C-s soon after. > My suggestion was not to filer based on project-files, but rather simply > by file name prefixes. Which, if I read correctly, is exactly what your > patch v2 does. Ah yes. >> The patches could be combined, but v1 seems to be too invasive for >> emacs-29, yet v2 could be just small enough to be considered >> "bugfix-only". >> >> So, what does everyone think about the latter? >> >> If people agree that the v2 patch is an improvement, we can check it >> in and leave project-local histories until later. > In fact I think v2 already is a completely satisfactory implementation > the project-local file history feature. It seems like there are two incompatible behaviors here and you and Juri want. One is to filter by current project, and another to be able to reuse previous inputs freely. If forced to choose, I would be slightly inclined toward the latter (which could be implemented using text properties, although the concept is a little awkward). But both are reasonable. I think we should install one of them and then later (on master) add a user option to switch to the other behavior.