From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: feature/completions-highlight-modifications e3c5b99 3/6: Add completions-highlight-mode initial implementation. Date: Mon, 16 Nov 2020 13:31:36 -0800 (PST) Message-ID: References: <20201115023629.19537.77471@vcs0.savannah.gnu.org> <20201115023631.C78AB20A27@vcs0.savannah.gnu.org> <20201115224943.o5r7lkkblmyt2ox4@Ergus> <20201116033719.63dryvqm4ozfer2r@Ergus> <92f3cbd7-29a0-461a-a023-562bc6020ea8@default> <87v9e5herj.fsf@mail.linkov.net> <9d7ae465-2eb7-4193-93d2-50d2cb90210e@default> <87v9e53v1z.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="582"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ergus , Stefan Monnier , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 16 22:33:05 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kem7V-000Aa2-5B for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Nov 2020 22:33:05 +0100 Original-Received: from localhost ([::1]:52160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kem7U-000721-7c for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Nov 2020 16:33:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kem6C-0005qZ-MF for emacs-devel@gnu.org; Mon, 16 Nov 2020 16:31:44 -0500 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:47686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kem6A-0008SF-Et for emacs-devel@gnu.org; Mon, 16 Nov 2020 16:31:43 -0500 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AGLOG8A068051; Mon, 16 Nov 2020 21:31:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=wu+/6Lnkk2Y2CCnlGPTrcGKfe4nHTlAxFcjnWZUDm2o=; b=mI0Sxv8ZzSQeeLC+jLD1nPh1r/0ss/tzjf671XR/WmQUV81Zagm/kP3sGNtTY7x0/Ezx ZazXOZNCtgjamH6EUuslAjXHUhf/qX7BOdHpkEyJjb7H0clmYJ0IDNBYGTx1mG+RMUqs NDt4djc+wOFPcTbqrG0PGJ55icL6v6W8sztfUzwfw2xDwDHkYF6hvjjLldeYfgXb40PM I0565QxA4PWIR0Atz25WbjYAYmG6xdDZnHzVKWIaSA47CDDEgvg+wUR5TVI9+5FUVllv n5JOwHHuoSsn/Go6vTEbZWx7qIcki8PAcAyeKZ0QqmbSbxANsbCNV9jL3UqTfKCvk2/S Vg== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 34t4raqjk4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 16 Nov 2020 21:31:39 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AGLQTAe150590; Mon, 16 Nov 2020 21:31:39 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 34ts5v7700-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Nov 2020 21:31:39 +0000 Original-Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0AGLVc7v015112; Mon, 16 Nov 2020 21:31:38 GMT In-Reply-To: <87v9e53v1z.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9807 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 phishscore=0 suspectscore=0 mlxscore=0 malwarescore=0 bulkscore=0 mlxlogscore=898 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011160127 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9807 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 clxscore=1015 malwarescore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=917 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011160127 Received-SPF: pass client-ip=141.146.126.79; envelope-from=drew.adams@oracle.com; helo=aserp2130.oracle.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 16:18:31 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259260 Archived-At: > > Icicles uses `C-insert' to move the cursor back and > > forth between the minibuffer and *Completions*. It > > moves between the current candidate in the minibuffer > > (from cycling) to/from the same candidate in > > *Completions*. >=20 > What the default completions implementation is still missing > is a command/key to insert the selected completion > from the the *Completions* buffer to the minibuffer > without exiting the minibuffer. Does it have a key that moves from a completion candidate in the minibuffer (e.g. from cycling) to the same candidate in *Completions*? That's also missing, AFAIK, in addition to placing the current completion in the minibuffer as you cycle. No? The same key should be used for both operations: minibuffer to *Completions* and *Completions* to minibuffer. And it should go to the "current" completion candidate in each case. And it should be a key that's not ordinarily used for editing, if it's made available in the minibuffer. For example, we shouldn't use a key such as `insert'. ___ It's already the case that perfectly fine self-inserting keys (`?', `SPC') have been excluded, in the minibuffer, from their ordinary behavior (self-inserting). That was misguided, IMO. It took us decades to finally get `SPC' to be self-inserting, and even then, it's only for `read-file-name', not `completing-read'. Why it was assumed that completion candidates would/should not contain space chars or question marks, I don't know.