From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#71605: 30.0.50; [PATCH] Support variable-width text in 'visual-wrap-prefix-mode' Date: Thu, 20 Jun 2024 10:36:23 -0700 Message-ID: References: <868qz3ssu0.fsf@gnu.org> <201c2285-012f-fa29-03b5-78a2e26aa134@gmail.com> <86plsfqvme.fsf@gnu.org> <66e7c49d-adb6-186f-18f1-33eee9f668ad@gmail.com> <86h6dqqy63.fsf@gnu.org> <86iky5p34b.fsf@gnu.org> <8269125b-7e9c-ffde-be9e-4a07c42ce6a5@gmail.com> <86o77wnrb7.fsf@gnu.org> <060e1362-a206-4c88-b49f-60e4f5da7238@gmail.com> <86a5jgndev.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25939"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71605@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 20 19:38:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKLjp-0006Yo-82 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Jun 2024 19:38:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKLjV-0001pD-6H; Thu, 20 Jun 2024 13:38:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKLjS-0001ld-4S for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 13:37:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKLjR-0002Mh-Su for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 13:37:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sKLjV-0003dB-RH for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 13:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2024 17:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71605-submit@debbugs.gnu.org id=B71605.171890505513908 (code B ref 71605); Thu, 20 Jun 2024 17:38:01 +0000 Original-Received: (at 71605) by debbugs.gnu.org; 20 Jun 2024 17:37:35 +0000 Original-Received: from localhost ([127.0.0.1]:37825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKLj5-0003cG-Ey for submit@debbugs.gnu.org; Thu, 20 Jun 2024 13:37:35 -0400 Original-Received: from mail-pl1-f182.google.com ([209.85.214.182]:59543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKLj3-0003bp-ES for 71605@debbugs.gnu.org; Thu, 20 Jun 2024 13:37:34 -0400 Original-Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1f700e4cb92so10533195ad.2 for <71605@debbugs.gnu.org>; Thu, 20 Jun 2024 10:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718904983; x=1719509783; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=S79QFlP2CFQI9mYUvZH/qgcawJAxFjPN+xjo4kFrJfY=; b=ekL8vV5WtUWJSkxqgeff6YDRsZUTsX2+4n+N5rhal1zjlOXEvqIOOODtp4gMaO64sf WqB78Gf7OJIrcKWNHkuXD3XX22XMb2rArXRPVgYplepVdl3ihhosK19IFIb2UPfLCDiQ uUO3BENwLM2eEdGLsWZmn31jnHGZWSC2O50DbHFvc5/q9V6NjsL11to0dFWapRNmT+5N v+sSD44ibnS1iXphsSWzZloPyHb/cDbjUX2sfO4SVd+oV64aGu4leqVpVmrYtvLm2dd3 QlLyplDR9t2AEPnzmNAAtmMTWQxnuodsRAedi84TbVQkmUXHnYVUdK/MlpMc15/17rxN p7Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718904983; x=1719509783; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S79QFlP2CFQI9mYUvZH/qgcawJAxFjPN+xjo4kFrJfY=; b=Z/8ZtOs3682VJnDZ1YOvDUIsKOQYUX2RHkeuhF7VpM+RfiMucZJ/N909DENOmbwwM9 xSWGlyn6Ua71bb3Sj9TDUxaZjux8iaFi6MOEvNgjQ84dQuLkx69UeEAd0yaIR8uGU24w xEosiJMOn1+DqN++8ONgnDRWnVIsE6D8L49nK2svvcElQhMhWObSIgX68U7gn/HyIyck /I4ym+VI5/rGhpVXQ+DEMcuH0NXOUCJGQuVz0n3jbQnaUtLdjy14R/CS6QdYJE9nQQVe QHlgjkkdnEpEiRW31Ug01CJ5qF/tUO3xRaWaSRGAJoBA0URZTytQRIi9wvjhefTg4FdA 1PIQ== X-Gm-Message-State: AOJu0Yy6foZ1YoJGVIhA2olLN8nPzCu6ngSwGT6QSE5/VaCXcDo37qMd wtFNUWG7p5HFZKicDO+o8qsTRRcq1Tjr+UX3SIJ0GgXywp4KlH7EXy6hGA== X-Google-Smtp-Source: AGHT+IGSgUdA4Q4oPJM7czNb4jMsV8oLj2OLCqn0xA1E2R9U6TB3vc19w5oDFETXAqK44TuilZM7lA== X-Received: by 2002:a17:902:cece:b0:1f7:167d:e289 with SMTP id d9443c01a7336-1f9aa466115mr71810645ad.55.1718904983183; Thu, 20 Jun 2024 10:36:23 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f9dada68c4sm9620705ad.229.2024.06.20.10.36.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jun 2024 10:36:22 -0700 (PDT) Content-Language: en-US In-Reply-To: <86a5jgndev.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287580 Archived-At: On 6/20/2024 2:58 AM, Eli Zaretskii wrote: > Should be fixed now on the master branch. Thanks, it all seems to work now. I think I have a way forward to implement this that should avoid issues, though it's a bit more complex than I'd initially thought. I think there are three cases: "* here is some text": Text Properties "* " (display (min-width (2))) "here is some text" (wrap-prefix (space :align-to 2)) " here is some text": Text Properties " " (display "") " here is some text" (line-prefix (space :align-to 2) wrap-prefix (space :align-to 2)) "// here is some text" (in c-mode): Text Properties "// here is some text" (wrap-prefix "// ") (The last case is just doing what visual-wrap-prefix-mode currently does.) I'm pretty sure all these should be unproblematic in the scenarios Po Lu mentioned. The only case I haven't considered is how this interacts with 'visual-wrap-extra-indent'. I'll have to think about that some more.