all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#45264: 26.3; `face-remap-set-base' seems to be bugged
@ 2020-12-16  0:31 Drew Adams
  2020-12-19 10:20 ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Drew Adams @ 2020-12-16  0:31 UTC (permalink / raw)
  To: 45264

See https://emacs.stackexchange.com/a/62301/105

(defface foo '((t (:background "red"))) "...")

(face-remap-set-base 'font-lock-keyword-face 'foo)

The &rest arg SPECS is `(foo)', which is, as required, a list of
(one) face.

But the code actually expects `foo' itself to be a list.  It raises
an error, because it sets SPECS to just `foo' and then tries to
take the car of it.

(while (and (consp specs)
            (not (null (car specs)))
            (null (cdr specs)))
  (setq specs (car specs))) ; <=========

(if (or (null specs)
    (and (eq (car specs) face) ; <=========
         (null (cdr specs))))

Is there a doc bug (both manual and doc string)?  Or is there a code
bug?  Or am I missing something?


In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32)
 of 2019-08-29
Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd
Windowing system distributor `Microsoft Corp.', version 10.0.18362
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''





^ permalink raw reply	[flat|nested] 6+ messages in thread
[parent not found: <<dbc9cd7f-c4da-4137-a972-aada49e0f1f1@default>]
[parent not found: <<<dbc9cd7f-c4da-4137-a972-aada49e0f1f1@default>]

end of thread, other threads:[~2020-12-19 19:40 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-16  0:31 bug#45264: 26.3; `face-remap-set-base' seems to be bugged Drew Adams
2020-12-19 10:20 ` Eli Zaretskii
     [not found] <<dbc9cd7f-c4da-4137-a972-aada49e0f1f1@default>
     [not found] ` <<833602umgb.fsf@gnu.org>
2020-12-19 18:32   ` Drew Adams
2020-12-19 18:58     ` Eli Zaretskii
     [not found] <<<dbc9cd7f-c4da-4137-a972-aada49e0f1f1@default>
     [not found] ` <<<833602umgb.fsf@gnu.org>
     [not found]   ` <<4efb5c63-6636-449f-8e2b-4b8533a9cc8c@default>
     [not found]     ` <<83a6u9tyh1.fsf@gnu.org>
2020-12-19 19:28       ` Drew Adams
2020-12-19 19:40         ` Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.