From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#35228: 26.1; Please consider adding a doc string for `extended-command-history' Date: Thu, 11 Apr 2019 08:43:58 -0700 (PDT) Message-ID: References: <2085c19d-d6de-40e2-aaad-1ff941b95397@default> <87y34g4mzm.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="27058"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35228@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 11 17:47:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEbv1-0006si-JS for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Apr 2019 17:47:15 +0200 Original-Received: from localhost ([127.0.0.1]:51055 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEbv0-0007W1-55 for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Apr 2019 11:47:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEbup-0007UC-5N for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 11:47:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEbuo-0004fN-5z for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 11:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41508) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEbun-0004fF-U6 for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 11:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hEbun-00060D-Ms for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 11:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Apr 2019 15:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35228 X-GNU-PR-Package: emacs Original-Received: via spool by 35228-submit@debbugs.gnu.org id=B35228.155499757423015 (code B ref 35228); Thu, 11 Apr 2019 15:47:01 +0000 Original-Received: (at 35228) by debbugs.gnu.org; 11 Apr 2019 15:46:14 +0000 Original-Received: from localhost ([127.0.0.1]:55052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEbu1-0005z7-QY for submit@debbugs.gnu.org; Thu, 11 Apr 2019 11:46:14 -0400 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:58480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEbtz-0005yu-MK for 35228@debbugs.gnu.org; Thu, 11 Apr 2019 11:46:12 -0400 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3BFXhxb135691; Thu, 11 Apr 2019 15:46:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=axqwaCJBbIUHBlw4gW0CLR6xrxXMl26JsG1rJV8GrQU=; b=X2ZDu/24yI0D8ySu+jwLVaNQFPvj2gFfX8cjwWaWBLXJi1DXnhrioALpXzoD2vQV+IpR CkbN7E6VRlmtJar7WVPJlUFT39mVDcLbE5OI/R5NdTfgzK0MY3sJHZdh/hYNcs1Z08Ao VC10pryyCSQqAmEYLcTYv6i9clu9+0xSNXoFd5w/T/8QY3Hdss7d8Awn8wIv+lxur+zb GBg1iIBbVWQSBJ6FmjvPJNkQVPMrzFC4X5VqeH6sYLJ2/3AVI8QwaSfBPw1gpV3SQ8cH 2O0yaBOO2+zmftB7jXfGswU17CL5OVAmAAXDt3qDqFv16Z7ynkBWHjQ7eJO1V7D9uwdh BA== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 2rphmesy64-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Apr 2019 15:46:03 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3BFhgKY152300; Thu, 11 Apr 2019 15:44:03 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2rpytcue0h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Apr 2019 15:44:02 +0000 Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x3BFhxUJ016506; Thu, 11 Apr 2019 15:44:00 GMT In-Reply-To: <87y34g4mzm.fsf@tcd.ie> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4834.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9224 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904110105 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9224 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904110105 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157505 Archived-At: > How's the following? OK. But I think it should say that it's a history list for functions, such as `read-from-minibuffer', that read input in the minibuffer. It should perhaps also say that the commands in question are Emacs commands (as opposed to, say, shell commands or whatever). That's what "extended command" means, but it wouldn't hurt to make this clear. BTW, the Elisp manual says (only) this: "A history list for arguments that are names of extended commands." That's in node `Minibuffer History', which covers what is involved generally (so it should cover what "arguments" means here). However, I think it's wrong for the descriptions in that node to speak of "arguments". There is only ever one HISTORY arg for any given minibuffer-reading function call. What's said now is unclear, I think. It would be good to fix this language too. Anyway, for this doc string how about something like this? "Minibuffer history list for names of Emacs commands. It is used by function `execute-extended-command'. An Emacs command is anything that satisfies predicate `commandp'. A minibuffer history list is used by functions such as `read-from-minibuffer' that read input in the minibuffer. The maximum effective length of such a list is controlled by the value of variable `history-length'." Do we need to mention `history-length' or to remind users what a minibuffer history and an Emacs command are? Perhaps not, but it doesn't hurt.