From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Thu, 15 Feb 2018 14:02:03 -0800 Message-ID: References: <20180215193047.GA5448@breton.holly.idiocy.org> <62b22b44-2c40-4cca-a25a-d588353cd1fa@email.android.com> <20180215203525.GA12965@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1518732106 15318 195.159.176.226 (15 Feb 2018 22:01:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Feb 2018 22:01:46 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 Cc: Eli Zaretskii , Angelo Graziosi , emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 15 23:01:41 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emRap-0002r1-EM for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 23:01:27 +0100 Original-Received: from localhost ([::1]:36254 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emRcq-0003Lh-Cw for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 17:03:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emRbZ-0003Jm-Vv for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:02:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emRbZ-0006v1-3g for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:02:14 -0500 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:56280) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emRbY-0006uX-QX; Thu, 15 Feb 2018 17:02:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=HLqn/mZpMZR+x1eplg1glCtxn5/Sx4EONRx69DEQqoU=; b=NlQ6/4y4UQ5Lxx2pOF+v3Ty5eUVRxOeFO9O5PK6zz7ORJakGsa9I89Iq6pu3bb4+jY8M+KQ0lHtmOMY+sDmF50EUI0PfhcWfLv3Ph1k85RxMb5dgSO80zaHdwQkL4G7AqQfEm+0G0V7iGB1g/RoudYEMgsG9JrEwoI+OiE7q5FN/ZgDnviVeTW2t+suF6vq1EYn1SOL4BL9ZF/pjxBj50tVIRSo0Fm3KNwHHd+ZSrWc1d4C+tJxe+oVFvVsO4Sr8+BEx2XhQOXuF8m1Z0q+vPLwRDdpZ5juMH7MiYH0VNLqum4LhfiMX53deQ3V2oSlZh8HHIukZAUFwlf8jY5My6Q==; Original-Received: from [2604:4080:1321:8ab0:709e:8a18:8cea:1501] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1emRbW-0002My-N7; Thu, 15 Feb 2018 14:02:10 -0800 In-Reply-To: <20180215203525.GA12965@breton.holly.idiocy.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222774 Archived-At: On 02/15/2018 12:35 PM, Alan Third wrote: > On Thu, Feb 15, 2018 at 11:49:30AM -0800, Daniel Colascione wrote: >> Thanks for checking. If you disable Wconversion at the top of the >> file, you should be able to unblock yourself. The warning helps make >> the code robust, but it's annoying to account for compiler >> differences. > > Thanks, I’ve got it to build and it seems to work fine. > > Here are the changes I had to make: All fixed, I think. > @@ -1646,7 +1646,7 @@ static int macfont_variation_glyphs (struct font *, int c, > unsigned variations[256]); > static void macfont_filter_properties (Lisp_Object, Lisp_Object); > > -static struct font_driver const macfont_driver = > +static struct font_driver macfont_driver = > { > .type = LISPSYM_INITIALLY (Qmac_ct), > .get_cache = macfont_get_cache, > @@ -4034,6 +4034,18 @@ So we use CTFontDescriptorCreateMatchingFontDescriptor (no > > Why did you have to remove the const?