From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Sun, 23 Apr 2023 02:37:50 +0300 Message-ID: References: <87a5zj2vfo.fsf@gmail.com> <83mt3d73c2.fsf@gnu.org> <87r0sptinq.fsf@posteo.net> <83jzyh706c.fsf@gnu.org> <875ya1tdwf.fsf@posteo.net> <83edop6sdy.fsf@gnu.org> <831qkp6o0i.fsf@gnu.org> <83wn2h5825.fsf@gnu.org> <87wn2gkhzr.fsf@posteo.net> <83cz485oxi.fsf@gnu.org> <87leiwdyff.fsf@posteo.net> <834jpk5hih.fsf@gnu.org> <871qkom3fj.fsf@posteo.net> <83mt3b4yfc.fsf@gnu.org> <87edonlsxi.fsf@posteo.net> <83jzyf4vzb.fsf@gnu.org> <871qknllkj.fsf@posteo.net> <83fs934pjf.fsf@gnu.org> <87wn2fk47y.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15168"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: larsi@gnus.org, 62720@debbugs.gnu.org, monnier@iro.umontreal.ca, joaotavora@gmail.com To: Philip Kaludercic , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 23 01:39:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pqMp9-0003l0-GF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Apr 2023 01:39:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqMoq-0005e2-CM; Sat, 22 Apr 2023 19:39:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqMoo-0005db-Jy for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 19:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqMoo-0004hq-C9 for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 19:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pqMon-0006Q4-RR for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 19:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Apr 2023 23:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.168220668224606 (code B ref 62720); Sat, 22 Apr 2023 23:39:01 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 22 Apr 2023 23:38:02 +0000 Original-Received: from localhost ([127.0.0.1]:44312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqMnq-0006Oo-E0 for submit@debbugs.gnu.org; Sat, 22 Apr 2023 19:38:02 -0400 Original-Received: from new2-smtp.messagingengine.com ([66.111.4.224]:36265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqMnn-0006OK-M8 for 62720@debbugs.gnu.org; Sat, 22 Apr 2023 19:38:01 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 7CF53581DA6; Sat, 22 Apr 2023 19:37:54 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 22 Apr 2023 19:37:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1682206674; x=1682210274; bh=SZjpqwtn9fBRStksrQ5r+NoMMdm5oL4RKLT 2UbfUSPU=; b=ousCGqtyS1smzUtPFOe5iQmPQx4c8jrB7MStc7k4wHi92zlcQGG BglM00Erl+jLHFW1RVothBE5/oSXbya+5THkgFciWpsJiHank9Li17ZwHB3+XzCE nEzI/kY+oS/MRaAP3LiFrCIfCIMPLIYXW8L0ltXsqErZZJB0c0N7NMDTguSZtSNa CtUoytf3+s43a0nUY5KQ+IYk9YFnLotavgwyCW7YeOWNde92PkzqZa7teSdq2hvY HTWwMQFPV2qQFcOR8qKWQ3kSUSU7bIK8i93XgwXWDKNB1jsUjOXph5wEwLusD71l 8fl8NBPUpBpKbq8Yd3q5J2YT4WX2280Bd3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1682206674; x=1682210274; bh=SZjpqwtn9fBRStksrQ5r+NoMMdm5oL4RKLT 2UbfUSPU=; b=IvsGCWaT+GNQf5wKTqOOht+1ynzOXDTiBP+TaAuSdF822cGdVUJ eB9v8dWRbowBks3nd7cLuzDch5Yo4brn9xIy2gmfWIYnG9zDCvsB09fzFAO//Iuc TLSaZCm9mD1wRJ3W29h2RrJZPJ4EE/Ahuu3/CxzmFk+xoEwTVLkAXNEbkGYkgR3T FZtt9wMUCzvmoI84QJNU12+2muOMkvbi5OATD1f9/EYxVfMY34j0eHMutBuiGbrd eUSCDrR1+DhiejV4G/c3MI367T0uhmIxo6r8Ue7Ml+nA2ZfDGVEdUWV38sxL2I2M QJ8jzJPiUeAsh4VLiGl+rwoxFAVCYLcpERg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtjedgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 22 Apr 2023 19:37:52 -0400 (EDT) Content-Language: en-US In-Reply-To: <87wn2fk47y.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260488 Archived-At: Philip, On 13/04/2023 21:49, Philip Kaludercic wrote: > + (when (and (or current-prefix-arg package-install-upgrade-built-in) > + (package--active-built-in-p pkg)) > + (setq pkg (cadr (assq name package-archive-contents)))) How sure are you that the first element in (cdr (assq name package-archive-contents)) will contain the latest version? When reading the code I stumbled on these two items: - Comment in package-compute-transaction: ;; pkg-descs is sorted by priority, not version, so ;; don't error just yet. - package-menu--find-upgrades iterates through installed packages and checks for new versions with this condition: (version-list-< (package-desc-priority-version pkg-desc) (package-desc-priority-version avail-pkg)) That's why I came with the more complex way to choose the appropriate package-desc in my latest attempt: (car (last (seq-sort-by #'package-desc-priority-version #'version-list-< (cdr (assq package package-archive-contents))))) Would be happy to hear it's an overkill and we can use the more simple version.