From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Using Emacs in fbterm. Date: Tue, 30 Aug 2022 21:20:06 +0000 Message-ID: References: <83czcjvtt2.fsf@gnu.org> <874jxu4zeg.fsf@igel.home> <87v8qa3k0b.fsf@igel.home> <83r10yufto.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36920"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , acm@muc.de, schwab@linux-m68k.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 23:21:19 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT8fe-0009Mz-RZ for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 23:21:18 +0200 Original-Received: from localhost ([::1]:46748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT8fd-00064M-El for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 17:21:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT8eZ-0005Dm-Ds for emacs-devel@gnu.org; Tue, 30 Aug 2022 17:20:11 -0400 Original-Received: from heytings.org ([95.142.160.155]:46096) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT8eX-0005iG-R6; Tue, 30 Aug 2022 17:20:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1661894407; bh=C44SpwHD1px9fra7pxBE3SgkeWlq+ReyqKBLxA3FTYY=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=IAMZnQ/FlqE0ESLvSTTSYPB2pqEcGT0XJecJbAu3cK+tIz/NYHKVcLtKswe+MH9fo +gxNuczg73+rfc1cUA3tY5riCxmpfw4dhoa2KTtIjV2hXD20Iwcsxc7nHrmnWyua5v O+jn2MK2YP4q1D5jPR/o8ORhYOH2vKd21/AYbEOncmPkbfW1r0csb6UEVOYxLpGHJq q9SixzKZv0+LW47jdST2/7voonNYyL1fBoMJrL7/OgVOiTXZ0ZZVSf1TyX5ZIP4Urd CnC/mE8w0rJbUC1B2ZJb5f11nysalTQOiFPVg9AXED/ZaPKHIWjjLYWoASB5SloilE EYkwCKqOdoL5g== In-Reply-To: Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294387 Archived-At: >>> Hmm... this seems to point to a problem/shortcoming in `t-mouse.el` >>> which should arguably do that automatically, no? >> >> I confess I blindly copied that line from linux.el, thinking it was >> probably useful for something. > > It should probably be removed from there as well. If it causes a > regression that should be fixed in `t-mouse.el` or at the very least > come with a clear description of the problem it fixes. > I cannot do that on the release branch, but feel free to do so on master. Note that the two last commits which modified that line are yours. The ignore-errors appears to come from 4a364c5ef2: "Don't signal an error if gpm isn't running." It seems to me that indeed t-mouse.el already handles that case by itself, but I'm not 110% sure.