From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f) Date: Sun, 20 Oct 2013 16:27:07 -0700 (PDT) Message-ID: References: <87ppv550s6.fsf@web.de> <309ce668-1d40-4865-b796-d6828f65a8d4@default> <49fae9c3-c59c-4b08-84f0-24dc9935b345@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1382311701 10981 80.91.229.3 (20 Oct 2013 23:28:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Oct 2013 23:28:21 +0000 (UTC) Cc: Michael Heerdegen , 14734@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 21 01:28:24 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VY2Q3-0006ns-DN for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2013 01:28:23 +0200 Original-Received: from localhost ([::1]:37713 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VY2Q2-0003CQ-Pi for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2013 19:28:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VY2Pr-0003C6-LL for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2013 19:28:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VY2Pj-0003yW-2d for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2013 19:28:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VY2Pi-0003yS-VT for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2013 19:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VY2Pi-0007Zx-9l for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2013 19:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2013 23:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 14734-submit@debbugs.gnu.org id=B14734.138231163629076 (code B ref 14734); Sun, 20 Oct 2013 23:28:02 +0000 Original-Received: (at 14734) by debbugs.gnu.org; 20 Oct 2013 23:27:16 +0000 Original-Received: from localhost ([127.0.0.1]:59603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VY2Oy-0007Yu-1J for submit@debbugs.gnu.org; Sun, 20 Oct 2013 19:27:16 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:36561) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VY2Ov-0007Yd-BA for 14734@debbugs.gnu.org; Sun, 20 Oct 2013 19:27:13 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r9KNR6W1017744 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 20 Oct 2013 23:27:06 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9KNR5Sw013881 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 20 Oct 2013 23:27:05 GMT Original-Received: from abhmt108.oracle.com (abhmt108.oracle.com [141.146.116.60]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9KNR4Rg020492; Sun, 20 Oct 2013 23:27:04 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:79434 Archived-At: > the old advice.el was made to work on top of the new nadvice.el (the > total size of the new advice.el and nadvice.el is about the same as > the old advice.el). But the new advice, and now the old advice too, since it is on top of the new, does NOT work. Specifically, there is this regression wrt doc strings. This should not be a `wont-fix' bug. It should be fixed. It should be fixed in the advice system that is documented in the manuals, which for now is still the "old" system (there is nothing about the nadvice stuff in the manuals). If the "new" system will at some point replace the old and itself be documented differently, instead of being only, as you say now, internal, then it too will need to be fixed wrt its handling of the doc string.