From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 29279@debbugs.gnu.org
Subject: bug#29279: Sharing the margins
Date: Mon, 13 Nov 2017 21:16:30 +0200 [thread overview]
Message-ID: <d9e4b108-c738-73f8-3257-61219ebeee8b@yandex.ru> (raw)
In-Reply-To: <83o9o6kp61.fsf@gnu.org>
On 11/13/17 8:29 PM, Eli Zaretskii wrote:
>> I'm not sure I understand the "Zero means ..." passage, though.
>
> That's your "total width" thing, for margin users that just want to
> set the overall width of the margins without displaying anything
> there. Like Joost Kramer's visual-fill-column and similar packages.
OK, but why "maximum width"? workroom-mode wanted to set the total
width, but if we want to describe what will happen with the column in
question, the value sounds more like "minimum total width".
>> In addition to signifying a neutral position, does it supposed to switch
>> the meaning of this function into something that
>> set-right-margin/set-left-margin can call, for backward compatibility?
>
> Yes, set-window-margins will most probably be reimplemented by calling
> the above.
Which area will the left-margin specs be drawn on, then? Ones without
any particular symbol specified.
>> Seems like a wart, using ORDINAL this way. And what's going to happen
>> when somebody else calls window-margin-add with non-zero ORDINAL? Will
>> the end result depend on which call happens first?
>
> Yes. And the result is returned, so the caller knows that. If you
> have better ideas for requesting a particular position in the margin,
> let's hear them.
Having ORDINAL to be a number is totally fine to me.
Having ORDINAL = 0 mean something else, not so great. Especially if the
result is to have the padding in this column, necessary to reach the
specified total width.
I imagine workroom-mode might have a idea where they want the padding to
end up (to the left or to the right of all columns). So instead of
co-opting the ORDINAL argument to mean "cols will total cols"
>> Here's an interesting question: after such an API is added, will it be
>> feasible to re-implement display-line-numbers-mode using a margin
>> column, instead of the special separate area?
>
> Yes. But using margins from Emacs internals means that the
> window-parameters which hold the column specs will change behind the
> back of the Lisp applications, which I'm not sure is a Good Thing.
I was thinking more along the lines of being able to specify a
spec-returning function (that uses the current buffer position), instead
of only using the text properties. But changing the margins directly
sounds faster.
Maybe not an entirely good thing, but certainly an improvement for the
authors of third-party code.
> It will also be somewhat slower.
We should probably measure before discarding this idea.
next prev parent reply other threads:[~2017-11-13 19:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 23:51 bug#29279: Sharing the margins Dmitry Gutov
2017-11-13 15:43 ` Eli Zaretskii
2017-11-13 17:24 ` Dmitry Gutov
2017-11-13 18:15 ` Eli Zaretskii
2017-11-13 19:02 ` Dmitry Gutov
2017-11-13 19:22 ` Eli Zaretskii
2017-11-13 19:33 ` Dmitry Gutov
2017-11-13 15:46 ` Eli Zaretskii
2017-11-13 17:54 ` Dmitry Gutov
2017-11-13 18:29 ` Eli Zaretskii
2017-11-13 19:16 ` Dmitry Gutov [this message]
2017-11-13 19:32 ` Eli Zaretskii
2017-11-13 21:16 ` Dmitry Gutov
2017-11-14 15:30 ` Eli Zaretskii
2017-11-14 22:39 ` Dmitry Gutov
2017-11-15 3:42 ` Eli Zaretskii
2017-11-15 14:23 ` Dmitry Gutov
2017-11-15 18:00 ` Eli Zaretskii
2017-11-15 21:49 ` Dmitry Gutov
2017-11-16 15:50 ` Eli Zaretskii
2017-11-18 23:55 ` Dmitry Gutov
2017-11-19 15:34 ` Eli Zaretskii
2017-11-20 22:23 ` Dmitry Gutov
2017-11-21 15:40 ` Eli Zaretskii
2017-11-15 18:51 ` martin rudalics
2017-11-15 20:03 ` Eli Zaretskii
2017-11-15 21:09 ` Dmitry Gutov
2017-11-16 15:39 ` Eli Zaretskii
2017-11-18 23:46 ` Dmitry Gutov
2017-11-19 15:30 ` Eli Zaretskii
2017-11-19 0:47 ` Joost Kremers
2017-11-19 9:20 ` Dmitry Gutov
2017-11-14 9:54 ` martin rudalics
2017-11-14 15:51 ` Eli Zaretskii
2017-11-15 18:50 ` martin rudalics
2017-11-14 9:54 ` martin rudalics
2017-11-14 15:51 ` Eli Zaretskii
2017-11-14 18:30 ` martin rudalics
2017-11-14 19:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9e4b108-c738-73f8-3257-61219ebeee8b@yandex.ru \
--to=dgutov@yandex.ru \
--cc=29279@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.