From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Shanavas M Newsgroups: gmane.emacs.bugs Subject: bug#30905: Add tests for buffer-base-buffer function Date: Wed, 28 Mar 2018 12:41:40 +0300 Message-ID: References: <311E1CBF-963A-4429-B69D-4C62B01D0178@disroot.org> <87po3sqt4j.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------77F8BC8BD43CB957758312AA" X-Trace: blaine.gmane.org 1522248798 10340 195.159.176.226 (28 Mar 2018 14:53:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Mar 2018 14:53:18 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 To: 30905@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 28 16:53:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1CRs-0002Z5-PG for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Mar 2018 16:53:13 +0200 Original-Received: from localhost ([::1]:39653 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1CTw-0003KK-8D for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Mar 2018 10:55:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1CTk-0003E8-GP for bug-gnu-emacs@gnu.org; Wed, 28 Mar 2018 10:55:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f1CTg-00016S-GS for bug-gnu-emacs@gnu.org; Wed, 28 Mar 2018 10:55:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49597) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f1CTf-00015p-Q7 for bug-gnu-emacs@gnu.org; Wed, 28 Mar 2018 10:55:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f1CTf-0005vs-JK for bug-gnu-emacs@gnu.org; Wed, 28 Mar 2018 10:55:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Shanavas M Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Mar 2018 14:55:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30905-submit@debbugs.gnu.org id=B30905.152224886522713 (code B ref 30905); Wed, 28 Mar 2018 14:55:03 +0000 Original-Received: (at 30905) by debbugs.gnu.org; 28 Mar 2018 14:54:25 +0000 Original-Received: from localhost ([127.0.0.1]:57486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1CT2-0005uG-Gf for submit@debbugs.gnu.org; Wed, 28 Mar 2018 10:54:25 -0400 Original-Received: from knopi.disroot.org ([178.21.23.139]:38742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f17ag-0004wq-Ca for 30905@debbugs.gnu.org; Wed, 28 Mar 2018 05:41:58 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 31D212CFC3 for <30905@debbugs.gnu.org>; Wed, 28 Mar 2018 11:41:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1522230112; bh=BkuaTsO6qo55+67jfxrt8kXkZzEvtPvQ4WbRFHaufYE=; h=Subject:To:References:From:Date:In-Reply-To; b=AGYOUXRwpz39XIwJSeZwLMw5ieLE8VPLiAorXrEX40yupT8AaOU/0OTl7AjqWPIei jSwRPobxdwbjR6Jn5uF3/niO4uphu0Dn16doNOPrBt6TlqtU2Ghw9qUMqG7+GFyuPO Kr3lWbcni9WLT0rzNnT9f9d2C5EEuOMq1+CHqRpntclQN/A46tI0koJmvkX7xvmljB NwNreNVUHS1duPpYLf/dK7OnJ4T5PVIXKyKmxmyn/GB5Hcwa6jn9pkbcK5bw7HLrj8 /zHn2gR8aVGAlXoV9bxXRsztZibu2IrU1fQnMH490o9HjukdUQYXEeTtJnO9eXQ89h qwaKy0dnT/ZqA== X-Virus-Scanned: Debian amavisd-new at disroot.org Original-Received: from knopi.disroot.org ([127.0.0.1]) by localhost (mail01.disroot.lan [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jpleCeJU2qXn for <30905@debbugs.gnu.org>; Wed, 28 Mar 2018 11:41:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1522230110; bh=BkuaTsO6qo55+67jfxrt8kXkZzEvtPvQ4WbRFHaufYE=; h=Subject:To:References:From:Date:In-Reply-To; b=ecWIS+G/5ynxXpPCdHA+GDTUqyjAfoljR3PRQmMsv/upB4aEzy/dA7VHc3lbverQJ n51kkKqDPJtb2ykiqcoArPof+vBQisc3n1IxWN8WE3bUTAMD1ylL9YKlO48v8mMUgW GUA/GhP8OpGbUPIl3P00s1UR+kYoEB1GYWtrssUQdQauQmVpYch7+cPzLb5dBQHj0f zFSccdxFEvQUz7GbfiBrbWjhH1GmXdtjxuLOxchgwui31oL88XzHUAt6MNYjmw5hG0 FI4QdfkeBkkpZmFg9Eu82X3aRRCPT86XKTk31MpR30doceLLxNJyvCYHCIHPAxLrqv yZIg3jQiIQ8ng== In-Reply-To: <87po3sqt4j.fsf@gmail.com> Content-Language: en-US X-Mailman-Approved-At: Wed, 28 Mar 2018 10:54:22 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144667 Archived-At: This is a multi-part message in MIME format. --------------77F8BC8BD43CB957758312AA Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On Sunday 25 March 2018 02:42 PM, Noam Postavsky wrote: > A couple of things. > > Have assigned copyright for Emacs? (the change is small enough to > install regardless, but note that we only accept up to 15 lines worth of > unassigned code per person). I have send the request. Waiting for reply. > You should add a ChangeLog style entry to the commit message, as > described in CONTRIBUTE. Updated > >> +(ert-deftest test-buffer-base-buffer-indirect () >> + (let* ((base (get-buffer-create "base") > You should rather use with-temp-buffer, so that the test will not > interfere with anything else (same for the second test). > Updated. > --------------77F8BC8BD43CB957758312AA Content-Type: text/x-patch; name="0001-Add-tests-for-buffer-base-buffer-function.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Add-tests-for-buffer-base-buffer-function.patch" >From c1627cb453a6aceba36305417d5ac6b1e63e7021 Mon Sep 17 00:00:00 2001 From: Shanavas M Date: Thu, 22 Mar 2018 12:20:22 +0300 Subject: [PATCH] Add tests for buffer-base-buffer function * test/src/buffer-tests.el (test-buffer-base-buffer-indirect) (test-buffer-base-buffer-non-indirect): Add tests for `buffer-base-buffer' --- test/src/buffer-tests.el | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/test/src/buffer-tests.el b/test/src/buffer-tests.el index f9c477fbfd..d115e66817 100644 --- a/test/src/buffer-tests.el +++ b/test/src/buffer-tests.el @@ -50,4 +50,14 @@ (progn (get-buffer-create "nil") (generate-new-buffer-name "nil"))))) +(ert-deftest test-buffer-base-buffer-indirect () + (with-temp-buffer + (let* ((ind-buf-name (generate-new-buffer-name "indbuf")) + (ind-buf (make-indirect-buffer (current-buffer) ind-buf-name))) + (should (eq (buffer-base-buffer ind-buf) (current-buffer)))))) + +(ert-deftest test-buffer-base-buffer-non-indirect () + (with-temp-buffer + (should (eq (buffer-base-buffer (current-buffer)) nil)))) + ;;; buffer-tests.el ends here -- 2.11.0 --------------77F8BC8BD43CB957758312AA--