From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Introducing thread-safe Tramp Date: Wed, 8 Aug 2018 19:49:39 +0300 Message-ID: References: <8736wa9c5s.fsf@gmx.de> <3e63b230-6cc1-f517-da71-57b892e14e30@yandex.ru> <87wotfhdn2.fsf@gmx.de> <87sh42gyf0.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1533746867 18559 195.159.176.226 (8 Aug 2018 16:47:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Aug 2018 16:47:47 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 08 18:47:43 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnRcd-0004kq-7i for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2018 18:47:43 +0200 Original-Received: from localhost ([::1]:44688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnRej-0002wB-NN for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2018 12:49:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnRed-0002sJ-4A for emacs-devel@gnu.org; Wed, 08 Aug 2018 12:49:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnRea-0001Nc-0d for emacs-devel@gnu.org; Wed, 08 Aug 2018 12:49:47 -0400 Original-Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]:36307) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fnReZ-0001Lr-Om for emacs-devel@gnu.org; Wed, 08 Aug 2018 12:49:43 -0400 Original-Received: by mail-lj1-x236.google.com with SMTP id u7-v6so2267756lji.3 for ; Wed, 08 Aug 2018 09:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IYYaxIry5rmfDoyJ3W55DgLnxk1MgkosKEuIHWb/XJM=; b=kNN6rx01uxS1QX3Z4LaIpWI6cUrsxBwFctWVnfQSnZTwy+XgYk6VktnrqahW2CfnPc K5PpwfQ88A1TWidk+3VT1MOPmM0Zfw5pKoNgdaeBnXAr0UJ1Z9zcMIP7vyvo6T/wbcuD tFRLCSRs3hMwd70Q8cYL16/FVCoYlK1uInCsUBR0ez1ro9ztfIl68Fpo9xjWIDcdz615 FchuWD3T6NhZ/4Uj0GkP2W9Hip8PjL6qHw8Z+yMSQjjOgefMDjy5CAjCHToWOQv6rLwt NnwLXoTKk3cBO0yDbS6Q9CUwljQp3qRrIxnyeUYgh5rrAQL8KfdvDjAPznWuVPR6ydEI PDSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IYYaxIry5rmfDoyJ3W55DgLnxk1MgkosKEuIHWb/XJM=; b=DBZLGiNqQo6GbEd3Of3xCq2IBLesSQcILhWp0ePC+p+fpjl423Pf8FEdzduKEn4R5f 3GRGPD54BGNDHHDId6MEsnsHDx6CB1CAEyLe4qCyaOsqqHAs9gHPHPqyQM4wWUguC5rn UNQCTv5TeRk3PGJ7V1f9fYU8PFCv7bbv/FyuLCCiO/tyRxxiIftaplz8vIPqNuFVvjFc kYsA1JGCFnQpo6MZ4G4+MfMAtp73aSCfJFc+3oAV1ntznArZk16hG9RsvgDIkMdoKD0P 6YRCB/+AOiAmvzT2YCVXupEV3QNghrV4VHN44vx9ojEsms4aQEjvuxWFJ4TbRskSj7n5 6nwA== X-Gm-Message-State: AOUpUlGjp7mgZWYQ4JtkzpLMlkHy2UheO8gzTbVDrz8PagWocyK83CLm cCZ6fGGorEn2/hE2GHJ7RQpSyVRw X-Google-Smtp-Source: AA+uWPwasezbNp+E9EoKVnSuXp8KRp3u124PdSquwGWEnz2M27xzq31FY1JC1gbUEb1ktNNvqDPMXw== X-Received: by 2002:a2e:2114:: with SMTP id h20-v6mr2743546ljh.135.1533746981838; Wed, 08 Aug 2018 09:49:41 -0700 (PDT) Original-Received: from [192.168.1.174] ([178.252.127.223]) by smtp.googlemail.com with ESMTPSA id m66-v6sm903015lfi.17.2018.08.08.09.49.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Aug 2018 09:49:40 -0700 (PDT) In-Reply-To: <87sh42gyf0.fsf@gmx.de> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228312 Archived-At: On 7/29/18 12:54 PM, Michael Albinus wrote: > vc-refresh-state works over the current buffer, vc-state works over a > file (which is missing in your example). (vc-state buffer-file-name), then. We don't have a counter-part for vc-refresh-state that takes a file as an argument, so it's to be expected that some clients will use with function. E.g. with with-current-buffer. > I don't see after a short look > in the sources, how they depend. The result of your code snippet would > always be the result of vc-state, which is not threaded. My point is that before your branch, the result would be different. It would make sense to preserve the behavior. >>> Well, you are much more experienced with vc than I do. Look at the >>> changes I've done in vc-hooks.el, and adapt. >> >> I'm not well-versed on the use of Emacs threads, though. Yet. > > Me too, some weeks ago :-) It isn't that hard. I'll try to make some time.