From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#23098: 25.0.92; (recenter -1) can leave point in the middle of the window Date: Sun, 27 Mar 2016 08:07:24 -0700 (PDT) Message-ID: References: <87r3f19gx0.fsf@loki.jorgenschaefer.de> <83d1ql2ebx.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1459091308 3824 80.91.229.3 (27 Mar 2016 15:08:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Mar 2016 15:08:28 +0000 (UTC) Cc: Jorgen =?UTF-8?Q?Sch=C3=A4fer?= , 23098@debbugs.gnu.org To: Andreas Schwab , John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 27 17:08:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1akCIW-0006Zm-Da for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Mar 2016 17:08:12 +0200 Original-Received: from localhost ([::1]:36257 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akCIV-0007VZ-3q for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Mar 2016 11:08:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akCIQ-0007V4-Ul for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2016 11:08:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akCIL-00046p-Tl for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2016 11:08:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akCIL-00046l-Pn for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2016 11:08:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1akCIL-0003T0-Mf for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2016 11:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Mar 2016 15:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23098 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23098-submit@debbugs.gnu.org id=B23098.145909125413290 (code B ref 23098); Sun, 27 Mar 2016 15:08:01 +0000 Original-Received: (at 23098) by debbugs.gnu.org; 27 Mar 2016 15:07:34 +0000 Original-Received: from localhost ([127.0.0.1]:40183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akCHu-0003SI-9I for submit@debbugs.gnu.org; Sun, 27 Mar 2016 11:07:34 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:36959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akCHr-0003S5-TW for 23098@debbugs.gnu.org; Sun, 27 Mar 2016 11:07:32 -0400 Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u2RF7PKA010045 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 27 Mar 2016 15:07:25 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id u2RF7PkY006714 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 27 Mar 2016 15:07:25 GMT Original-Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u2RF7PKC017387; Sun, 27 Mar 2016 15:07:25 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115557 Archived-At: > > (add-to-list > > 'erc-mode-hook > > #'(lambda () (set (make-local-variable 'scroll-conservatively) 100))= ) >=20 > You should use add-hook for hook variables. Also (nits): 1. No need to use #' with lambdas (no advantage in a context that expects a function). 2. It is generally a good idea to use a named function (not a lambda) on a hook. For one thing, removing it is easier and more robust (`remove-hook') - no worries about differences in whitespace etc. 3. Emacs now has `setq-local': `(setq-local VAR VALUE)'. (I too use `(set (make-local-variable VAR) VALUE)', but mainly because I usually need code that works also for older Emacs versions.)