From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands Date: Thu, 19 Jan 2023 12:20:48 -0800 Message-ID: References: <20e5cb2f-aabe-53fd-d3af-81ec5ff11e7b@gmail.com> <83wn5jyq69.fsf@gnu.org> <83o7qunwgh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15128"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60942@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 19 21:22:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIbQP-0003ng-R2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 19 Jan 2023 21:22:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIbQC-0004q5-IZ; Thu, 19 Jan 2023 15:22:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIbQB-0004pw-1y for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 15:22:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIbQA-0005GD-QE for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 15:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pIbQA-0007n4-A4 for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 15:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Jan 2023 20:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60942 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60942-submit@debbugs.gnu.org id=B60942.167415966229858 (code B ref 60942); Thu, 19 Jan 2023 20:22:02 +0000 Original-Received: (at 60942) by debbugs.gnu.org; 19 Jan 2023 20:21:02 +0000 Original-Received: from localhost ([127.0.0.1]:44819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIbPB-0007lP-Og for submit@debbugs.gnu.org; Thu, 19 Jan 2023 15:21:02 -0500 Original-Received: from mail-pf1-f172.google.com ([209.85.210.172]:43673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIbP6-0007ku-6C for 60942@debbugs.gnu.org; Thu, 19 Jan 2023 15:21:00 -0500 Original-Received: by mail-pf1-f172.google.com with SMTP id c26so2386133pfp.10 for <60942@debbugs.gnu.org>; Thu, 19 Jan 2023 12:20:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=8di0cpO/4RNU7xtp32B+sXs2OAt9wZ3pn+4uWmGBr5E=; b=m+8GX/1Smk5I8IswMbDgftaX37MU/YZdKDymLIjvv5O1XR4Fbbw15QjShhvZtkjtBz mCyhAdnIOpMyEgm/TGDKOA+GxI6njDBH/ZtwS2GRhbb0Uo9K2aoa37LtzPXLsXcPRb59 H/8HyCspG0//JoT7awhFYCtDJ619kXmCth+yFo1Phsi9rx6zi2gyiPz94y96YSonkLVF jjMMBY9W+n34adeMzHrh09RVi/fjncTm9ak9g00gtAxaCAP6AY1cHhmNmsZlZjncuL84 OuZILqaa0+CjFFOb/neetZWYyygpSz8JVkzXWv4Ry+NJhO93mS1J754w9OaKyT9R2bL9 p8Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8di0cpO/4RNU7xtp32B+sXs2OAt9wZ3pn+4uWmGBr5E=; b=kzD1lLmRoDMwfcJm1PymBWJ1pyZ90vOZms8Ctp11LFSRjjhhFNN55fAjXTfmhKX3U0 9rFa/lesch7yViMq6Cm9KA8Ehe/FDNqIl0iqOH7sB55s4N3Y0pqoRFwXl6O3q+QvnX0C 6MBJIY+7Ne0ae1S8m7txhzEftPxK0IC1Lqocwyk/0wN9sIC/ynXfeOh5glE6/lNXoadK tbJbX0xHLZrNL+xr9J84a9dVY/F+V9Z2YHvY5y633plQ8dfcz3dDKAfZVrLURPh1OxKA 5zhgG1KKhha4fbNI1J3oH3/9mMnyFpnqaGkLfblttNvOmUImxz7d48m0aylSDxmpACTJ 1wBA== X-Gm-Message-State: AFqh2kpxycpcJsvEkZZqZXNr8YztTYeK5bTznUEab2Up8wrb5Rzq+9Ix T2Ljs12+Z4fo0LUuZAweLNo= X-Google-Smtp-Source: AMrXdXuJUZPzbd6zN0zTSTuSJQipS+J0rWJ4N+YGnGKt5QYV7I9ECq1r0GFRyuv+C18TGk9hVM2vTg== X-Received: by 2002:a62:e401:0:b0:575:e8c5:eb14 with SMTP id r1-20020a62e401000000b00575e8c5eb14mr11909567pfh.18.1674159650161; Thu, 19 Jan 2023 12:20:50 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a69-20020a621a48000000b0056b9df2a15esm16307643pfa.62.2023.01.19.12.20.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 12:20:49 -0800 (PST) Content-Language: en-US In-Reply-To: <83o7qunwgh.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253729 Archived-At: On 1/19/2023 11:41 AM, Eli Zaretskii wrote: > Is this for master? If so, okay. Otherwise, you'll need to adjust > the version in the obsolescence declaration. Personally, I think just for master. The change isn't entirely risk-free. This code is a bit tricky, and I'd want a fair amount of time for people to identify bugs, just in case I regressed something. (If this were for the release branch, we could probably remove 'eshell-eval-indices', since it was introduced in Emacs 29 anyway.)