From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jared Finder via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68765: 30.0.50; Adding window-tool-bar package. Date: Tue, 26 Mar 2024 08:34:11 -0700 Message-ID: References: <07df5e8408054bcae5968066b0cebf34@finder.org> <86fry0vihy.fsf@gnu.org> <86fry08di9.fsf@mail.linkov.net> Reply-To: Jared Finder Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39095"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 68765@debbugs.gnu.org, Philip Kaludercic , Stefan Monnier To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 26 16:35:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rp8po-0009qa-Nq for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Mar 2024 16:35:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rp8pN-0001Sm-8Q; Tue, 26 Mar 2024 11:35:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rp8pL-0001Rx-AF for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2024 11:35:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rp8pL-0006VQ-0P for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2024 11:35:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rp8pK-0002A6-I5 for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2024 11:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jared Finder Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Mar 2024 15:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68765 X-GNU-PR-Package: emacs Original-Received: via spool by 68765-submit@debbugs.gnu.org id=B68765.17114672538150 (code B ref 68765); Tue, 26 Mar 2024 15:35:02 +0000 Original-Received: (at 68765) by debbugs.gnu.org; 26 Mar 2024 15:34:13 +0000 Original-Received: from localhost ([127.0.0.1]:34481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rp8oX-00027N-8j for submit@debbugs.gnu.org; Tue, 26 Mar 2024 11:34:13 -0400 Original-Received: from greenhill.hpalace.com ([192.155.80.58]:38988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rp8oV-00027G-Tn for 68765@debbugs.gnu.org; Tue, 26 Mar 2024 11:34:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1711467251; bh=LiwCsscNPX9gRLjFJeGWk1fitLKpEIau1bwVtPIw7XE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zqncPH4fgNAxetv1IdiyDONU6N43VSqlrUnkDh3Zd8fdibtQTgkKCs4FPs6/ZZqPR ogue46H+wrfedrPlxSGiur3wgsjLOT3zt7lk0bv/WIt8/OOwQ9If0inurX6+bsf0+H TRLdLffxjQRKjUbTcLSnwN+yh++S7YmscvyxUlXzDe5f0JhNEPFnPZkK3fqtD41t7M QtpBYXP7vo7KHG/5T2ahyTVq5C5QQX8oo6bpY3oL09Q/MneYk77xQxXDMhloYJ7SnK 3tU7p9DBi7hGQPQ9nF9O1amFYvtJTZi2xoAVTywlwOt7HWFGvTYbwxxzZQ4MsW/J4L IvUge9gZYC+0A== Original-Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id D798860A; Tue, 26 Mar 2024 15:34:11 +0000 (UTC) In-Reply-To: X-Sender: jared@finder.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282093 Archived-At: It's been four weeks and I've seen no reply to this comment. Are there any other concerns? -- MJF On 2024-02-26 14:38, Jared Finder wrote: > On 2024-02-10 09:25, Juri Linkov wrote: >>>> * lisp/tab-line.el (tab-line-format-template): Add separator space. >>>> (tab-line-display-order): New user variable to control display >>>> order. >>>> (tab-line--runtime-display-order, tab-line--cookie): New internal >>>> variables. >>>> (tab-line-set-display): New function for modes to call to enable >>>> only >>>> their content. >>>> (tab-line-mode): Call `tab-line-set-display'. >>> >>> Juri, would you please review this part of the changeset? >> >> I'm not sure if this provides a clean interface. >> Have you tried to show both window-tool-bar and tab-line tabs >> on the same tab-line? Do you think this combination is usable? >> Or maybe better just repurpose the tab-line in window-tool-bar.el >> exclusively for window-local tool-bar? > > The implementation I provided works fine for me with both > window-tool-bar-mode and tab-line-mode enabled as long as there are not > too many tabs. I could see further adding a way to specify the max > width tabs are able to take up if you think that's necessary. > > -- MJF