From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master c22b735: (string-pixel-width): Rewrite to avoid side effects
Date: Sat, 30 Oct 2021 09:50:44 +0200 [thread overview]
Message-ID: <d8126a11-d823-5d11-da5e-c8bfb217eb3c@gmx.at> (raw)
In-Reply-To: <83y26ds1e5.fsf@gnu.org>
>> * src/xdisp.c (Fwindow_text_pixel_size): Allow `window` to be a buffer.
>> * lisp/emacs-lisp/subr-x.el (string-pixel-width): Simplify accordingly.
>
> Bother: this doesn't make sure w->contents is the current buffer,
> which I think many display routines assume without checking (or barf
> if it isn't true). So I think this is unsafe.
If WINDOW is a buffer (a not very tasteful and quite confusing idea
IMHO), 'window-text-pixel-size' will make that buffer current. The
problem is rather that the window that function operates on usually does
not show WINDOW and I have no idea which implications that could have.
martin
next prev parent reply other threads:[~2021-10-30 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 13:51 master c22b735: (string-pixel-width): Rewrite to avoid side effects Eli Zaretskii
2021-10-30 7:50 ` martin rudalics [this message]
2021-11-04 18:46 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8126a11-d823-5d11-da5e-c8bfb217eb3c@gmx.at \
--to=rudalics@gmx.at \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.