From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 44ebd9cbd56 2/2: Eglot: explain how to update Eglot in manual (bug#62720) Date: Thu, 4 May 2023 01:48:23 +0300 Message-ID: References: <168263878553.23108.4718240877999827191@vcs2.savannah.gnu.org> <20230427233949.44D31C22A13@vcs2.savannah.gnu.org> <20f53b0a-d6ff-8ec0-2f8c-e0e22b2d49dc@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9648"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: emacs-devel@gnu.org To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 04 00:49:28 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puLHq-0002HT-Hg for ged-emacs-devel@m.gmane-mx.org; Thu, 04 May 2023 00:49:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puLH7-0007uM-HI; Wed, 03 May 2023 18:48:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puLGy-0007tJ-IZ for emacs-devel@gnu.org; Wed, 03 May 2023 18:48:32 -0400 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puLGu-0007Na-ND for emacs-devel@gnu.org; Wed, 03 May 2023 18:48:32 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id E45D13200902; Wed, 3 May 2023 18:48:25 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 03 May 2023 18:48:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1683154105; x=1683240505; bh=e1ynbWdzf5xPMnQWyhOrJ4rXWaGfiHNMn86 OXBy3Yeg=; b=JP5Ag23PDRBJIO2IMCh58kkj+ql2DOllgp9lGKutXtmtDXlkqiK gjQSpeX/mZX4w+n/dUHazYe+eUqk/z93CKPup3C390JdnP8Nm4tiwnbNoyw33lZQ 39qM+m2Jkhhk9Bh9DZ6vq9uzQzwt4WNA0KiFlDx+qNf3vuXYpIRkeTRlmjDCVPWo h3RmmQ7n+jo2raLH0YU2EpJYAeAhhRA6Ob4d5fhpiJRVl5YYX/nmVein7ucVkGUU IqBbVnnU6HWDcy4ZoHcrz+AKpsRd5cb0DLcLC27Os+PBP/fF4CT6hPKkCsrozP0j DJ7oR0rIQmLK9hF2/4mDyq0tY7+YrRtx/LQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683154105; x=1683240505; bh=e1ynbWdzf5xPMnQWyhOrJ4rXWaGfiHNMn86 OXBy3Yeg=; b=QhrolTuqJnHEgDoByNNWcv1c35XjAd77KMqgFlKTEk7HSJSjlLX g5PeH/7dwioL7XUk0LmKbmTHTym2bC9hQaoKxRF/QkcBPBsq+w3d1pCo6hMgs7Uk 0H/PIhb0YtFCWCi0XtZ8B+dWnMGrkkWmUr7gjNTkgQmKH30XFWs+XqH06Hu1/xpp PbLbZbNdI4RslJ5pdYVyfhsFVs3RO6XrlIyFp886/Au+wfIfIjwh/3m1FtEsRp2x LBU1gvrDgQrMDaHFtvIIvgIemS8kVFRi/Voc+fanCYWpD3NmJml/RXnLxwqusqJA p+dXQZ/bVf7/wVNgE2YvqZHBMbkvZxCAOQQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedvledgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepvdetffektdfftdelledtgedtuddufffhvdeilefgfedujefhheeiueeugfeh geeunecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 May 2023 18:48:24 -0400 (EDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=64.147.123.20; envelope-from=dmitry@gutov.dev; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -70 X-Spam_score: -7.1 X-Spam_bar: ------- X-Spam_report: (-7.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-4.28, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305803 Archived-At: On 28/04/2023 03:35, João Távora wrote: > On Fri, Apr 28, 2023 at 12:53 AM Dmitry Gutov wrote: >> Hi! >> >> On 28/04/2023 02:39, João Távora wrote: >>> * lisp/progmodes/eglot.el (eglot-update): New command. >> Should it be called eglot-upgrade now as well? > No objection, don't feel strongly about it. If you want to > change it, go ahead, but remember to change the manual as > well. Ok, I did the rename. Two more things: - Commit 44ebd9cbd56 also removed the call to (eldoc) from the end of eglot-completion-at-point which has been there for a few years. Was that intentional? Didn't look like it. - Consider the issue that I brought up in https://debbugs.gnu.org/62720#715 regarding (cadr (assoc 'eglot package-archive-contents)). I'm not sure there's even a guarantee that the available versions are sorted, but even if they are obeying package-archive-priorities seems like a good idea. Though I can understand if it's not your first priority in this command.