From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#73736: 31.0.50; project and therefore eglot don't work without git Date: Fri, 11 Oct 2024 00:59:54 +0300 Message-ID: References: <878quv29hk.fsf@hassadar.pretzelnet.org> <0b0b919c-ef70-4bb3-bcb4-b471d9abd201@gutov.dev> <6a202181-19e3-a202-2e80-78b332633d4b@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22059"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: Jim Porter , Eric Gillespie , 73736@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 11 00:01:04 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sz1DS-0005Vf-MR for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Oct 2024 00:01:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sz1DJ-0001YK-Lk; Thu, 10 Oct 2024 18:00:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sz1DG-0001Xw-Mz for bug-gnu-emacs@gnu.org; Thu, 10 Oct 2024 18:00:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sz1DG-0005Z3-94 for bug-gnu-emacs@gnu.org; Thu, 10 Oct 2024 18:00:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=FP5hM52tRkGDI2q2sZOAIbGmgkh2EyfjRT3+Lz6GAgQ=; b=TW5dnafMJTk2nGYdZHQoJTDnsj5oX34UXxmJrVS0UCPPcE3LSGg1rg7jak2rhF974N42PdVfAIYIQrb2cVFl+kKxe9wGL7cLUErHRvZ5ou7mMOr7k8+hCLtA7aNlHMrnLQO777LkzwBaFnIfqChPkhxCECxH1PnbyGYa97yItoCwy5gKGBdpg6ZDseRGuqY1CC1hu2UXqc2fnRZgDiW6/ltE8mkzp2GBi2CrIaY1kxguQ7PSRfPOoyJ2OMN1gvAJ/4Gk/IuYfINGb4Q02+5IQKZaZr2bcm4V4+AUeMyo4hzTtoV/A1TdDP9B26inuk+ckJHbzQlwPC+uYPjR0JxzCg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sz1DS-0003mH-2y for bug-gnu-emacs@gnu.org; Thu, 10 Oct 2024 18:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Oct 2024 22:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73736 X-GNU-PR-Package: emacs Original-Received: via spool by 73736-submit@debbugs.gnu.org id=B73736.172859761914251 (code B ref 73736); Thu, 10 Oct 2024 22:01:02 +0000 Original-Received: (at 73736) by debbugs.gnu.org; 10 Oct 2024 22:00:19 +0000 Original-Received: from localhost ([127.0.0.1]:60773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sz1Cl-0003hj-3x for submit@debbugs.gnu.org; Thu, 10 Oct 2024 18:00:19 -0400 Original-Received: from fout-a6-smtp.messagingengine.com ([103.168.172.149]:43775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sz1Ci-0003ci-6E for 73736@debbugs.gnu.org; Thu, 10 Oct 2024 18:00:18 -0400 Original-Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id D3DD513801BC; Thu, 10 Oct 2024 17:59:58 -0400 (EDT) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Thu, 10 Oct 2024 17:59:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1728597598; x=1728683998; bh=FP5hM52tRkGDI2q2sZOAIbGmgkh2EyfjRT3+Lz6GAgQ=; b= eFL/9yEmFQeYqwwm3DVPThp7AfopWsaWV1NkhgujDmn5hkKBh52zbFLa2wa4khtG /AYgLOSXSrmjFd7gJ3ENgrdOHI9/zb+n+ue7BQEdKaO/QcRETVMQ+kCHbvOHP1Jb dL5B+spk60QgrUwuW2ilBxUJHRP/KOx+yC3aQ91GVcGQC+jXF/TB0+fA1R+NOK1w dByXLd0/X8Zcw1sprt8rADreGi2RFatUy+LkWDmGArsM0Mqr6X6SDhlhWJclVILM B5XV1jqmL4RVXwxOcqtypNHtOYtnUMFU0VFFZMgjmEheWc/rRc/kkLs3XSgC8/lq FG3N49GeW30fNWjDeh0EbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1728597598; x= 1728683998; bh=FP5hM52tRkGDI2q2sZOAIbGmgkh2EyfjRT3+Lz6GAgQ=; b=f IOAdUnHxrFoZD4zsYi8UyZlzF0Eymjsz7fgCzuwseglnqTxb/8x9x5Wr18V7Z5Vr YzSrUhlRzFqI56gKM1VwweSyyh6lpyUGqnRvy6EAnXgPzKIo2wxMOtnio21PW4N2 HtUaDEvrigb5eEpJBhST89AnbfY4NJ6ySNlugcLIo6rOWoMwEpE5HekI99HVUfYs 4aaeS34XzoiPpsBA3p+7fMLwFIo07o/4EtYRcViOq8NMGTiEO5JcCkh+qH0vJjm1 Mwr9/0CKbvfIFwSi+GzqtkjbyBhXLbZj1+f8gZyiavs39/atOgvRm/sBe1J4tYXs WZlQ/rdlezFGQHebO2H3w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdefjedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfg fuvfhfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcu oegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvghrnheptdfhuedvtd evleegueelvedvjeevheffveevhedvuefftdefhfdvueeggfetgfdtnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtoh hvrdguvghvpdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphht thhopehjphhorhhtvghrsghughhssehgmhgrihhlrdgtohhmpdhrtghpthhtohepvghpgh esphhrvghtiigvlhhnvghtrdhorhhgpdhrtghpthhtohepjeefjeefieesuggvsggsuhhg shdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 10 Oct 2024 17:59:57 -0400 (EDT) Content-Language: en-US In-Reply-To: <6a202181-19e3-a202-2e80-78b332633d4b@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293316 Archived-At: On 10/10/2024 21:52, Jim Porter wrote: > On 10/10/2024 11:42 AM, Dmitry Gutov wrote: >> This isn't very plug-and-play, but you can customize project-vc-extra- >> root-markers to include any other files that distinguish the root of a >> project. For example, Cargo.toml. > > I wonder, could major modes provide project.el with some default values > for that option? Then rust-mode could add Cargo.toml, python-mode could > add pyproject.toml, and so on. That's a natural question, but it would result in different results for "current project" for files in the same directory (which often enough use different major modes). What we could have, it a variable which is added to globally in package autoloads - so if e.g. rust-mode is installed it could add Cargo to root markers. For rust-ts-mode we'd need to do that in the core, but then we'd also need a way to override I guess, because in some projects that still wouldn't be "root"... Speaking of JetBrains and VS Code's "Open project" method, we could have such as well - it would be a separate command or two ("open" and "close", maybe). If it's just for Eglot, though, maybe ideally it would have a separate detector for directories in which to run the language server in - it doesn't have to correspond to what the user considers to be the entire project's root (they might prefer it to be a parent directory). Not sure how automatic it can be in the general case, though, and it'd require Eglot to know about root markers for all supported languages.