From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#51297: 28.0.60; [PATCH] Update termcap/terminfo to indicate 16-color support Date: Thu, 4 Nov 2021 16:47:39 -0700 Message-ID: References: <5317d810-ac3c-23e3-e017-a057406ec6b8@gmail.com> <87y26om74o.fsf@miha-pc> <87v917o6e1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18940"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51297@debbugs.gnu.org To: Lars Ingebrigtsen , miha@kamnitnik.top Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 05 00:48:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mimSy-0004ll-6A for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Nov 2021 00:48:20 +0100 Original-Received: from localhost ([::1]:43340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mimSw-00075C-7U for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Nov 2021 19:48:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mimSg-000754-I9 for bug-gnu-emacs@gnu.org; Thu, 04 Nov 2021 19:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60597) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mimSg-0007uU-0W for bug-gnu-emacs@gnu.org; Thu, 04 Nov 2021 19:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mimSf-0000zH-Ro for bug-gnu-emacs@gnu.org; Thu, 04 Nov 2021 19:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Nov 2021 23:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51297 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo Original-Received: via spool by 51297-submit@debbugs.gnu.org id=B51297.16360696653737 (code B ref 51297); Thu, 04 Nov 2021 23:48:01 +0000 Original-Received: (at 51297) by debbugs.gnu.org; 4 Nov 2021 23:47:45 +0000 Original-Received: from localhost ([127.0.0.1]:43910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mimSP-0000yC-Ad for submit@debbugs.gnu.org; Thu, 04 Nov 2021 19:47:45 -0400 Original-Received: from mail-pg1-f178.google.com ([209.85.215.178]:39769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mimSO-0000xQ-CM for 51297@debbugs.gnu.org; Thu, 04 Nov 2021 19:47:44 -0400 Original-Received: by mail-pg1-f178.google.com with SMTP id g184so6804774pgc.6 for <51297@debbugs.gnu.org>; Thu, 04 Nov 2021 16:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=oglzMnEjsDlo2Y0dUVk9ltCX/Y5IilZOsbgQuJU1sP4=; b=hUmLtaAvJJra59r1+InrqXOOdGXMq5cFvprG6Ark1zPytdnS2yQmjc4Fhu6oRnBimh FVrDDB2T60S0MILlX274HlIijUEy3cNErCNGiDMYTy72bFh+78uk8iGm/iYL5ZRfAUHn 8+iGL6q8s9rEJCRRsAZk+ZVfYsm/YwR4CHbnzbRaK+uAsRKVCQGQAzQnDapeoiztpZdS uqBQyjmgf8uc3f1XH+tdi82Dw+xnlNjcJFth5BjMkqtId+v4NWUL7gn/AaVis9ds9wdk M+KgRL1KEiIAHVkYOXtaxQRxrEqqkP8wUt8v2geltmf10o0IyhQM8YJKbAt1dZ6zQROp jMtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oglzMnEjsDlo2Y0dUVk9ltCX/Y5IilZOsbgQuJU1sP4=; b=a3wrVyN4jAnzZmmYgyacv7e0+8BMzKPbv/WiCrrhKU4ZDx8zDcwf1J2rrCjH9oQJp5 KM2eUcshtXS1RSj1VML40+w/eeWW8LJttUEXbTN82MfE4YdbNqN4kWlskWAA5TYdMnHL dVrzvGU4bZIcfOCkNTbEcpXY7+JLoxK/NYc3Hxz0rzOgarrcOttLOhufDXVf8gARLRJe +dm+i/Q6OwPHRL5m9DYokDn2N/440X3RU0Q82B5BimnlljhBG7kYB0CBApqbrIr8N8E+ ujFxqCY5aU/rpeUpT9UrnIyRqST+EwRYvNJecWyef+iE4ce198PzfNkkm0tNqioFwrSG pXIg== X-Gm-Message-State: AOAM532uIHfJ7NYeQZjmh9yYpoLfzTPd9WpEdbq9pKfO7FJ3Qfrt4J47 FYrFY7vqUkAxl+Zfv4tjW1rX3VWY4iQ= X-Google-Smtp-Source: ABdhPJwYfsOcZnwWydYk/470YG9gF9Xj/p9ZNuoEAX6ilM5XDgo+AKbWCa1HD3CrDmPKpYb1nyciVA== X-Received: by 2002:a05:6a00:2283:b0:481:2014:d9cf with SMTP id f3-20020a056a00228300b004812014d9cfmr26259719pfe.80.1636069658303; Thu, 04 Nov 2021 16:47:38 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id w12sm8389531pjq.2.2021.11.04.16.47.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Nov 2021 16:47:37 -0700 (PDT) In-Reply-To: <87v917o6e1.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218957 Archived-At: On 11/4/2021 4:20 PM, Lars Ingebrigtsen wrote: > miha@kamnitnik.top writes: > >> In conclusion, I think we should update the terminfo, changing colors, >> setab and setaf, and leave term.el unchanged. Patch attached. >> >> From 158e84e403017d2bfc73d9dabeb44bb3ba48f4dc Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?Miha=20Rihtar=C5=A1i=C4=8D?= >> Date: Wed, 20 Oct 2021 10:24:19 +0200 >> Subject: [PATCH] Update terminfo to indicate 16-color support. >> >> * etc/e/eterm-color.ti: Indicate 16-color support. >> Do not merge to master. > > I think it's too late to put something like this in emacs-28. Do I > understand correctly that it's not needed in Emacs 29? Correct, there's already a fix for this in Emacs 29 from (I think) bug#50806. If it's too late to add this for 28, then I think we can close this. For Emacs 28, the only negative to not merging Miha's patch is that users will have to manually update eterm-color (and install it to their systems) if they want to be sure their terminfo database correctly represents the capabilities in Emacs 28's `term-mode'. That's probably not a big deal, and worst-case scenario, some commands might only use 8 colors instead of 16.