all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Nicholas Savage" <nick@nicksavage.ca>
To: "Lars Ingebrigtsen" <larsi@gnus.org>
Cc: 39912@debbugs.gnu.org, Stefan Kangas <stefankangas@gmail.com>
Subject: bug#39912: [PATCH] Open describe-function links in view-mode (Bug#39912)
Date: Wed, 09 Sep 2020 20:43:45 -0400	[thread overview]
Message-ID: <d796420f-8f18-4c6c-81c7-e3358d7597c4@www.fastmail.com> (raw)
In-Reply-To: <871rjbgugp.fsf@gnus.org>

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

Good call. I've changed it to using view-buffer-other-window instead, which I think gets us where we want to be - it opens the NEWS file in view-mode, but also in another window as is consistent with previous behaviour.

On Wed, Sep 9, 2020, at 05:39, Lars Ingebrigtsen wrote:
> "Nicholas Savage" <nick@nicksavage.ca> writes:
> 
> > -    (pop-to-buffer (find-file-noselect file))
> > +    (view-buffer (find-file-noselect file))
> 
> pop-to-buffer opens the NEWS buffer in a different window, though, while
> view-buffer stays in the same window.  So perhaps it should pop first
> and then call view-buffer?
> 
> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Open-describe-function-NEWS-links-in-view-mode-Bug-3.patch --]
[-- Type: text/x-patch; name="0001-Open-describe-function-NEWS-links-in-view-mode-Bug-3.patch", Size: 879 bytes --]

From b634e095982ff45bfb43363ae8fadaea20885800 Mon Sep 17 00:00:00 2001
From: Nick Savage <nick@nicksavage.ca>
Date: Tue, 8 Sep 2020 16:08:30 -0400
Subject: [PATCH] Open describe-function NEWS links in view-mode (Bug#39912)

* lisp/help-mode.el (help-news): Open describe-function NEWS links in
view-mode (Bug#39912)

Copyright-paperwork-exempt: yes
---
 lisp/help-mode.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/help-mode.el b/lisp/help-mode.el
index 9c2d1d7227..0dc6c9ffae 100644
--- a/lisp/help-mode.el
+++ b/lisp/help-mode.el
@@ -308,7 +308,7 @@ 'help-news
   :supertype 'help-xref
   'help-function
   (lambda (file pos)
-    (pop-to-buffer (find-file-noselect file))
+    (view-buffer-other-window (find-file-noselect file))
     (goto-char pos))
   'help-echo (purecopy "mouse-2, RET: show corresponding NEWS announcement"))
 \f
-- 
2.20.1


  reply	other threads:[~2020-09-10  0:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 18:22 bug#39912: 27.0.90; Probably introduced at or before Emacs version Felician Nemeth
2020-09-07 19:54 ` bug#39912: "Probably introduced at or before Emacs version ..." link should open NEWS read-only Nicholas Savage
2020-09-07 21:00   ` Lars Ingebrigtsen
2020-09-08  6:59     ` Andreas Schwab
2020-09-08  7:25       ` Stefan Kangas
2020-09-08  7:26         ` Andreas Schwab
2020-09-08 10:26       ` Lars Ingebrigtsen
     [not found]     ` <871rjdi0wb.fsf@nicksavage.ca>
     [not found]       ` <87v9go4kzq.fsf@gnus.org>
2020-09-08 11:26         ` Nicholas Savage
2020-09-08 13:54           ` Stefan Kangas
2020-09-08 20:27 ` bug#39912: [PATCH] Open describe-function links in view-mode (Bug#39912) Nicholas Savage
2020-09-08 21:01   ` Stefan Kangas
2020-09-08 21:04     ` Lars Ingebrigtsen
2020-09-09  0:14     ` Nicholas Savage
2020-09-09  9:39       ` Lars Ingebrigtsen
2020-09-10  0:43         ` Nicholas Savage [this message]
2020-09-10 13:19           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d796420f-8f18-4c6c-81c7-e3358d7597c4@www.fastmail.com \
    --to=nick@nicksavage.ca \
    --cc=39912@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.