From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthew Dempsky Newsgroups: gmane.emacs.bugs Subject: bug#5030: 23.1.50; Unexpected minibuffer tab completion behavior Date: Tue, 24 Nov 2009 17:23:05 -0800 Message-ID: References: Reply-To: Matthew Dempsky , 5030@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1259157018 1182 80.91.229.12 (25 Nov 2009 13:50:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Nov 2009 13:50:18 +0000 (UTC) To: 5030@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 25 14:50:11 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NDIFy-0007m6-52 for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Nov 2009 14:50:07 +0100 Original-Received: from localhost ([127.0.0.1]:35842 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NDIFx-0003e3-R5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Nov 2009 08:50:05 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ND6yf-0007xQ-Vm for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2009 20:47:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ND6yb-0007uM-4k for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2009 20:47:29 -0500 Original-Received: from [199.232.76.173] (port=55833 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ND6yb-0007uG-2T for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2009 20:47:25 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:48005) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ND6ya-0001F6-Gy for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2009 20:47:24 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAP1lMdR020060; Tue, 24 Nov 2009 17:47:22 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAP1U4E0018646; Tue, 24 Nov 2009 17:30:04 -0800 Resent-Date: Tue, 24 Nov 2009 17:30:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Matthew Dempsky Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Wed, 25 Nov 2009 01:30:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 5030 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5030-submit@emacsbugs.donarmstrong.com id=B5030.125911218718202 (code B ref 5030); Wed, 25 Nov 2009 01:30:04 +0000 Original-Received: (at 5030) by emacsbugs.donarmstrong.com; 25 Nov 2009 01:23:07 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.27]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAP1N50v018199 for <5030@emacsbugs.donarmstrong.com>; Tue, 24 Nov 2009 17:23:07 -0800 Original-Received: by qw-out-2122.google.com with SMTP id 9so1496394qwb.13 for <5030@emacsbugs.donarmstrong.com>; Tue, 24 Nov 2009 17:23:05 -0800 (PST) Original-Received: by 10.224.86.211 with SMTP id t19mr3626986qal.146.1259112185449; Tue, 24 Nov 2009 17:23:05 -0800 (PST) In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Tue, 24 Nov 2009 20:47:29 -0500 X-Mailman-Approved-At: Wed, 25 Nov 2009 08:42:58 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32907 Archived-At: On Tue, Nov 24, 2009 at 5:09 PM, Matthew Dempsky wrote: > =A0- The `(and pop-up-windows ...)' clause of `display-buffer' is > evaluated*, and calls `(set-window-dedicated-p window-to-use 'soft)'. > =A0- However, the `window--display-buffer-2' call then calls > `set-window-buffer', which sets `w->dedicated =3D Qnil'. Not sure if this is the best fix, but the patch below at least corrects this issue. It changes `display-buffer' so that `set-window-dedicated-p' is called after `window--display-buffer-2' in both clauses that use `display-buffer-mark-dedicated'. --- a/lisp/window.el +++ b/lisp/window.el @@ -1139,9 +1139,9 @@ consider all visible or iconified frames." ((or use-pop-up-frames (not frame-to-use)) ;; We want or need a new frame. (let ((win (frame-selected-window (funcall pop-up-frame-function)))) - (when display-buffer-mark-dedicated - (set-window-dedicated-p win display-buffer-mark-dedicated)) - (window--display-buffer-2 buffer win))) + (prog1 (window--display-buffer-2 buffer win) + (when display-buffer-mark-dedicated + (set-window-dedicated-p win display-buffer-mark-dedicated))))) ((and pop-up-windows ;; Make a new window. (or (not (frame-parameter frame-to-use 'unsplittable)) @@ -1157,9 +1157,9 @@ consider all visible or iconified frames." (get-largest-window frame-to-use t)) (window--try-to-split-window (get-lru-window frame-to-use t))))) - (when display-buffer-mark-dedicated - (set-window-dedicated-p window-to-use display-buffer-mark-dedicate= d)) - (window--display-buffer-2 buffer window-to-use)) + (prog1 (window--display-buffer-2 buffer window-to-use) + (when display-buffer-mark-dedicated + (set-window-dedicated-p window-to-use display-buffer-mark-dedicated)))) ((let ((window-to-undedicate ;; When NOT-THIS-WINDOW is non-nil, temporarily dedicate ;; the selected window to its buffer, to avoid that some of