From: Matthew Dempsky <matthew@dempsky.org>
To: 5030@emacsbugs.donarmstrong.com
Subject: bug#5030: 23.1.50; Unexpected minibuffer tab completion behavior
Date: Tue, 24 Nov 2009 17:23:05 -0800 [thread overview]
Message-ID: <d791b8790911241723t62075f83i5b01c9dced63ab4d@mail.gmail.com> (raw)
In-Reply-To: <d791b8790911241709n747a6deehff49ee4b188782ba@mail.gmail.com>
On Tue, Nov 24, 2009 at 5:09 PM, Matthew Dempsky wrote:
> - The `(and pop-up-windows ...)' clause of `display-buffer' is
> evaluated*, and calls `(set-window-dedicated-p window-to-use 'soft)'.
> - However, the `window--display-buffer-2' call then calls
> `set-window-buffer', which sets `w->dedicated = Qnil'.
Not sure if this is the best fix, but the patch below at least
corrects this issue. It changes `display-buffer' so that
`set-window-dedicated-p' is called after `window--display-buffer-2' in
both clauses that use `display-buffer-mark-dedicated'.
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -1139,9 +1139,9 @@ consider all visible or iconified frames."
((or use-pop-up-frames (not frame-to-use))
;; We want or need a new frame.
(let ((win (frame-selected-window (funcall pop-up-frame-function))))
- (when display-buffer-mark-dedicated
- (set-window-dedicated-p win display-buffer-mark-dedicated))
- (window--display-buffer-2 buffer win)))
+ (prog1 (window--display-buffer-2 buffer win)
+ (when display-buffer-mark-dedicated
+ (set-window-dedicated-p win display-buffer-mark-dedicated)))))
((and pop-up-windows
;; Make a new window.
(or (not (frame-parameter frame-to-use 'unsplittable))
@@ -1157,9 +1157,9 @@ consider all visible or iconified frames."
(get-largest-window frame-to-use t))
(window--try-to-split-window
(get-lru-window frame-to-use t)))))
- (when display-buffer-mark-dedicated
- (set-window-dedicated-p window-to-use display-buffer-mark-dedicated))
- (window--display-buffer-2 buffer window-to-use))
+ (prog1 (window--display-buffer-2 buffer window-to-use)
+ (when display-buffer-mark-dedicated
+ (set-window-dedicated-p window-to-use display-buffer-mark-dedicated))))
((let ((window-to-undedicate
;; When NOT-THIS-WINDOW is non-nil, temporarily dedicate
;; the selected window to its buffer, to avoid that some of
next prev parent reply other threads:[~2009-11-25 1:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 1:09 bug#5030: 23.1.50; Unexpected minibuffer tab completion behavior Matthew Dempsky
2009-11-25 1:23 ` Matthew Dempsky [this message]
2009-11-25 16:36 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2009-11-24 6:09 Matthew Dempsky
2009-11-25 2:24 ` Matthew Dempsky
2009-11-25 8:42 ` Matthew Dempsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d791b8790911241723t62075f83i5b01c9dced63ab4d@mail.gmail.com \
--to=matthew@dempsky.org \
--cc=5030@emacsbugs.donarmstrong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.