From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Thu, 15 Feb 2018 14:35:43 -0800 Organization: UCLA Computer Science Department Message-ID: References: <047a67ec-9e29-7e4e-0fb0-24c3e59b5886@dancol.org> <83zikjxt1j.fsf@gnu.org> <8360n6ruzu.fsf@gnu.org> <834m2nplmb.fsf@gnu.org> <83inr2oje6.fsf@gnu.org> <83bmwuogfb.fsf@gnu.org> <878trydrbo.fsf@red-bean.com> <87d15jo39q.fsf@ritchie.wxcvbn.org> <26497701-9de7-b91e-7ac3-4fb5949b436e@dancol.org> <496410d6-a0ba-769c-69a7-df4b7bb3bdf3@dancol.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------E08CDF81371535C697979512" X-Trace: blaine.gmane.org 1518734095 20623 195.159.176.226 (15 Feb 2018 22:34:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Feb 2018 22:34:55 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 To: Daniel Colascione , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 15 23:34:51 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emS71-0004Yr-P0 for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 23:34:43 +0100 Original-Received: from localhost ([::1]:38204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emS8z-0004Ze-MD for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 17:36:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emS85-0003oO-S9 for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:35:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emS81-0001xg-TH for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:35:49 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:42092) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1emS81-0001wz-HM for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:35:45 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9AF101616AE; Thu, 15 Feb 2018 14:35:44 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id HAG-RWYV_Kpn; Thu, 15 Feb 2018 14:35:43 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id AB8DE1616B1; Thu, 15 Feb 2018 14:35:43 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id H56wQyVYkQws; Thu, 15 Feb 2018 14:35:43 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 8E88C1616AE; Thu, 15 Feb 2018 14:35:43 -0800 (PST) In-Reply-To: <496410d6-a0ba-769c-69a7-df4b7bb3bdf3@dancol.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222779 Archived-At: This is a multi-part message in MIME format. --------------E08CDF81371535C697979512 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable I had the following problem on Fedora 27 when building the pdumper=20 branch just now: =C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 emacs.o emacs.c: In function =E2=80=98load_dump=E2=80=99: emacs.c:771:5: error: jump skips variable initialization=20 [-Werror=3Djump-misses-init] =C2=A0=C2=A0=C2=A0=C2=A0 goto out; =C2=A0=C2=A0=C2=A0=C2=A0 ^~~~ emacs.c:817:2: note: label =E2=80=98out=E2=80=99 defined here =C2=A0 out: =C2=A0 ^~~ emacs.c:800:15: note: =E2=80=98path_exec=E2=80=99 declared here =C2=A0=C2=A0 const char *path_exec =3D PATH_EXEC; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 ^~~~~~~~~ emacs.c:788:5: error: jump skips variable initialization=20 [-Werror=3Djump-misses-init] =C2=A0=C2=A0=C2=A0=C2=A0 goto out; =C2=A0=C2=A0=C2=A0=C2=A0 ^~~~ emacs.c:817:2: note: label =E2=80=98out=E2=80=99 defined here =C2=A0 out: =C2=A0 ^~~ emacs.c:800:15: note: =E2=80=98path_exec=E2=80=99 declared here =C2=A0=C2=A0 const char *path_exec =3D PATH_EXEC; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 ^~~~~~~~~ cc1: all warnings being treated as errors The attached patch fixes it. --------------E08CDF81371535C697979512 Content-Type: text/x-patch; name="0001-src-emacs.c-load_dump-Pacify-GCC-Wjump-misses-init.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-src-emacs.c-load_dump-Pacify-GCC-Wjump-misses-init.patc"; filename*1="h" >From 80c596f9a992c9424a5a15716a6639f5efedbed5 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 15 Feb 2018 14:34:49 -0800 Subject: [PATCH] * src/emacs.c (load_dump): Pacify GCC -Wjump-misses-init. --- src/emacs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/emacs.c b/src/emacs.c index 0d7c6ed9b3..7ed4f2758e 100644 --- a/src/emacs.c +++ b/src/emacs.c @@ -748,6 +748,7 @@ load_dump (int *inout_argc, /* Look for an explicitly-specified dump file. */ + const char *path_exec = PATH_EXEC; char *dump_file = find_and_remove_dump_file_argument (&argc, &argv); if (initialized && dump_file) /* TODO: maybe more thoroughly scrub process environment in order @@ -797,7 +798,6 @@ load_dump (int *inout_argc, FIXME: this doesn't work with emacs-XX.YY.ZZ.pdmp versioned files. */ argv0_base = "emacs"; - const char *path_exec = PATH_EXEC; #ifdef WINDOWSNT /* On MS-Windows, PATH_EXEC normally starts with a literal "%emacs_dir%", so it will never work without some tweaking. */ -- 2.14.3 --------------E08CDF81371535C697979512--