From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#64046: 30.0.50; Quoting in customize choice tags Date: Thu, 24 Aug 2023 17:14:53 -0300 Message-ID: References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11044"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Ola x Nilsson , 64046@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 24 22:16:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZGkd-0002gE-CG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Aug 2023 22:16:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZGkL-0000Nt-OU; Thu, 24 Aug 2023 16:16:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZGkI-0000Nj-6U for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 16:15:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZGkH-00013M-Uf for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 16:15:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZGkM-0000Yx-2L for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 16:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 20:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs Original-Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.16929081102096 (code B ref 64046); Thu, 24 Aug 2023 20:16:02 +0000 Original-Received: (at 64046) by debbugs.gnu.org; 24 Aug 2023 20:15:10 +0000 Original-Received: from localhost ([127.0.0.1]:38674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZGjV-0000Xk-MB for submit@debbugs.gnu.org; Thu, 24 Aug 2023 16:15:09 -0400 Original-Received: from mail-oo1-xc31.google.com ([2607:f8b0:4864:20::c31]:52566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZGjT-0000X7-35 for 64046@debbugs.gnu.org; Thu, 24 Aug 2023 16:15:08 -0400 Original-Received: by mail-oo1-xc31.google.com with SMTP id 006d021491bc7-570e88ee36aso180894eaf.1 for <64046@debbugs.gnu.org>; Thu, 24 Aug 2023 13:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692908097; x=1693512897; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8FFh/RHN4kPw0t9cKbsexI7yyffpR+lm3WLkny6jQFU=; b=KjZrk+qk0ZBaXRtxy0od7RFMWAsRi93TRsQl8nOK+/AsC7KIvNbrYgrB4GCTsuqfib AkbJYoVpk1hr1BSZzNVNgC7lVqBmUdRNmDY/45mOYrYq4JzO5YUP2lF/d3qP40mCgxDY IdHFbHLP/kmEruhAQiI2Ge7WCTuJZOqTc5eZiayV/iEZUE4ytE4pXsnWiqheQwvsSuJK Hh/InCUG60lIrtgJOURC9QWh6nSu2W42qsHhKjKBabJdRjcdSTMi28GvM72CWhUtoMh4 WkB9dR/PuaYKL2EqtLe7/KolunLlStMvwNhH8TtYzcs5wuKu7AReaGHaqKW0MvF/9zro G4sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692908097; x=1693512897; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8FFh/RHN4kPw0t9cKbsexI7yyffpR+lm3WLkny6jQFU=; b=JMwm/ZdU7TaXI0KUptDlOxYoEeYpY8ldPiJIbNbWUhZv6KWBtrVTiLB7kdMTqLPik+ rlK6BXGD4UcJyyRIAh/0Lpfig2iGf4T1Pcbp5QTKO7NJpDm+0GGZhRjahfmPl5YpIilw 2BhPqzFFwr66Fn+KPX1JN41hN3gojcAX6oo+7fRR4RfQHaN9XDAqdfDTk2ZH00l80nI0 xe7DOkaOqLF0K4zcAif7R3XA70X5Obuf4Gl/u2v0BBT+GXoaULpx4jFUaYlNcA4P7y+P lNKTJ4X9YOhVfzeNj2ptaQIqKiAJJF0eix4yHYDcpyoZw+fcISdwt0o02dGng4yZWL+c zRiw== X-Gm-Message-State: AOJu0YykLMfWaAas5jWzlo87FWTx7fEI75CM8etyGPERawLRCWehRY43 VoIZMrqYpssy3t8O50u8duk= X-Google-Smtp-Source: AGHT+IFu0kPAyMgeXEB2jyb426jDI5cwVKJTI0lK9SyAme7NkRn2eT6KmaV/O6DviNbeoRXMHwoizg== X-Received: by 2002:a4a:2443:0:b0:571:aceb:26ce with SMTP id v3-20020a4a2443000000b00571aceb26cemr3577007oov.1.1692908096907; Thu, 24 Aug 2023 13:14:56 -0700 (PDT) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id t186-20020a4a54c3000000b00567829a4991sm144807ooa.36.2023.08.24.13.14.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 13:14:56 -0700 (PDT) Content-Language: en-US In-Reply-To: <87bkewpogr.fsf@gmx.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268355 Archived-At: Stephen Berman writes: > Right after sending, I found an obvious problem: only one of the car or > the cdr might be a string.  The following patch accounts for this: > > diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el > index a70598bb6c9..891e98b6de5 100644 > --- a/lisp/wid-edit.el > +++ b/lisp/wid-edit.el > @@ -285,12 +285,18 @@ widget-choose >    ;; Apply quote substitution to customize choice menu item text, >    ;; whether it occurs in a widget buffer or in a popup menu. >    (let ((items (mapc (lambda (x) > -                       (when (consp x) > -                         (dotimes (i (1- (length x))) > -                           (when (stringp (nth i x)) > -                             (setcar (nthcdr i x) > - (substitute-command-keys > -                                      (car (nthcdr i x)))))))) > +                       (if (proper-list-p x) > +                           (dotimes (i (1- (length x))) > +                             (when (stringp (nth i x)) > +                               (setcar (nthcdr i x) > + (substitute-command-keys > +                                        (car (nthcdr i x)))))) > +                         ;; ITEMS has simple item definitions. > +                         (when (consp x) > +                           (when (stringp (car x)) > +                             (setcar x (substitute-command-keys (car x)))) > +                           (when (stringp (cdr x)) > +                             (setcdr x (substitute-command-keys (cdr x))))))) Thinking about it, why do we need to call substitute-command-keys on the VALUE part (i.e., the cdr of the cons cell), in case of simple item definitions? I re-read the bug report, but I didn't find any reference to why that is a need.  Did I miss something? (I'll be going on a trip for the weekend, so apologies if I can't see your response soon enough)