From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master f18af6c: Audit use of lsh and fix glitches Date: Wed, 22 Aug 2018 06:44:25 -0700 Organization: UCLA Computer Science Department Message-ID: References: <20180821204437.16880.99611@vcs0.savannah.gnu.org> <20180821204439.62390209A6@vcs0.savannah.gnu.org> <53d0c06e-2383-955a-0a17-650fd842b483@cornell.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1534945384 10207 195.159.176.226 (22 Aug 2018 13:43:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Aug 2018 13:43:04 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 To: Ken Brown , Pip Cet , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 22 15:43:00 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsTPX-0002Ua-Vm for ged-emacs-devel@m.gmane.org; Wed, 22 Aug 2018 15:43:00 +0200 Original-Received: from localhost ([::1]:59167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsTRe-0007wZ-EO for ged-emacs-devel@m.gmane.org; Wed, 22 Aug 2018 09:45:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsTR2-0007wU-N0 for emacs-devel@gnu.org; Wed, 22 Aug 2018 09:44:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsTQz-0006wL-DJ for emacs-devel@gnu.org; Wed, 22 Aug 2018 09:44:32 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:53656) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fsTQz-0006tM-7R for emacs-devel@gnu.org; Wed, 22 Aug 2018 09:44:29 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 07B5A1605BB; Wed, 22 Aug 2018 06:44:27 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id C6Yl27xF91CM; Wed, 22 Aug 2018 06:44:26 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 50650160656; Wed, 22 Aug 2018 06:44:26 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id FbIeChRcqTRC; Wed, 22 Aug 2018 06:44:26 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 01DA01605BB; Wed, 22 Aug 2018 06:44:25 -0700 (PDT) In-Reply-To: <53d0c06e-2383-955a-0a17-650fd842b483@cornell.edu> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228807 Archived-At: Ken Brown wrote: >> I think the previous code was correct: now we have bignums, we should >> no longer return 'unsupported on machines with 30/32-bit fixnums, >=20 > I think you're missing the point of that code.=C2=A0 The function is=20 > vc-hg-state-fast.=C2=A0 If it returns 'unsupported, that simply means t= hat the slower=20 > function will be used. True, but even bignums should be faster than the slow function, so the co= de=20 really shouldn't be worrying about integer width. Fixing this, though, wi= ll be a=20 bit trickier than simply removing the width check, as I expect the code u= ses eq=20 on integers. Until that assumption is fixed (or until we start hashing bi= gnums)=20 the integer width check still makes sense.