From: Jim Porter <jporterbugs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 60942@debbugs.gnu.org
Subject: bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands
Date: Wed, 18 Jan 2023 23:37:12 -0800 [thread overview]
Message-ID: <d5b6e127-9b79-2ef3-275e-ef274a953c7a@gmail.com> (raw)
In-Reply-To: <83wn5jyq69.fsf@gnu.org>
On 1/18/2023 10:49 PM, Eli Zaretskii wrote:
> Why do you remove a non-internal function? We cannot possibly do that
> if this is going to be installed on the emacs-29 branch. But even if
> you are going to install on master, why not leave that function alone?
> Some code somewhere could be using it, and we don't usually remove
> functions before a period of deprecation.
I can keep 'eshell-eval-indices' around and mark it obsolete if you
prefer; it wouldn't hurt anything. I could also fix this bug in that
function, though it would be an inferior fix compared to the new
'eshell-indices' function, so we definitely want that new function (or
something very similar). I'm not sure fixing 'eshell-eval-indices' is
worth it though, since I'd be very surprised if anyone called that
function directly.
For context, 'eshell-eval-indices' is a function I added in Emacs 29 to
fix some related issues with indices[1], but at the time I didn't fully
understand Eshell's internals and so implemented the fix incorrectly
(though it works for most common cases). It probably could have been
marked as internal at the time, but Eshell doesn't seem to do that
regularly, even for functions that external code would be very unlikely
to find useful.
[1] In particular, the second case in my original message fails even
more severely in Emacs 28:
~/config $ echo $exec-path[${echo 0}]
Wrong type argument: number-or-marker-p, (eshell-escape-arg (let
((indices 'nil)) (eshell-convert (eshell-command-to-value
(eshell-as-subcommand (eshell-trap-errors (eshell-named-command "echo"
(list #("0" 0 1 (number t))))))))))
next prev parent reply other threads:[~2023-01-19 7:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 3:36 bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands Jim Porter
2023-01-19 6:49 ` Eli Zaretskii
2023-01-19 7:37 ` Jim Porter [this message]
2023-01-19 19:31 ` Jim Porter
2023-01-19 19:41 ` Eli Zaretskii
2023-01-19 20:20 ` Jim Porter
2023-01-20 1:54 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5b6e127-9b79-2ef3-275e-ef274a953c7a@gmail.com \
--to=jporterbugs@gmail.com \
--cc=60942@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.