From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#36974: 26.2.90; [PATCH] Add imenu support to xref Date: Fri, 27 Dec 2019 16:50:31 +0300 Message-ID: References: <87h86rlvq8.fsf@cassou.me> <87imqoh57t.fsf@gnus.org> <878smyyt6o.fsf@cassou.me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="50445"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 36974@debbugs.gnu.org To: Damien Cassou , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 27 14:51:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ikq1H-000Cs4-S5 for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Dec 2019 14:51:12 +0100 Original-Received: from localhost ([::1]:35618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikq1G-0004Zv-Ka for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Dec 2019 08:51:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60181) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikq19-0004Zm-Po for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2019 08:51:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ikq17-0008Gd-TE for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2019 08:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50663) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ikq17-0008G0-NL for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2019 08:51:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ikq17-0001rd-Lt for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2019 08:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Dec 2019 13:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36974 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 36974-submit@debbugs.gnu.org id=B36974.15774546427138 (code B ref 36974); Fri, 27 Dec 2019 13:51:01 +0000 Original-Received: (at 36974) by debbugs.gnu.org; 27 Dec 2019 13:50:42 +0000 Original-Received: from localhost ([127.0.0.1]:56636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikq0n-0001r3-S1 for submit@debbugs.gnu.org; Fri, 27 Dec 2019 08:50:42 -0500 Original-Received: from mail-lf1-f51.google.com ([209.85.167.51]:45019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikq0l-0001qo-PW for 36974@debbugs.gnu.org; Fri, 27 Dec 2019 08:50:40 -0500 Original-Received: by mail-lf1-f51.google.com with SMTP id v201so20671336lfa.11 for <36974@debbugs.gnu.org>; Fri, 27 Dec 2019 05:50:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+h6MhbSolnHHx9GiU3D3X6e3O25DasiQNXZkmZr3xn4=; b=Mh6iL9bv6YbJBxzOa6KRm/s3dSEZjx4qTfOrIqkwISA6AMFH0MugTe82KU542Mh1Jp eUg/M0xVcrSzgA/jEgViukf2g/FlGa7E80Qe0pEhbodyaHNF7oCoOFXJoeZ7lV0DwoAV bNcJDitJTea+5GX8NqL6eiocSVxCYlQb74h3bEZRKks4SZIBLJtiJPmBrADyjwnmaBtR QFfmrn3kb6PfHhWjY2jRl4RAx7P8GhSa2JeAf7BUjSX38JisqFktK8DXKPDB92mequWZ N6LgX/109lYLH+10XOeuHPry9YoH7qVaSp0DD4jwUtoHKmSRQX2ELfR2fHcCsE3Bot9F RWug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+h6MhbSolnHHx9GiU3D3X6e3O25DasiQNXZkmZr3xn4=; b=ofE/f1J6QRpyo+y0P3S0IRzf6SmK8306QXE5PYWXmcJkASxFRA48UwrluT9bk39MGe kd3E4c/scogqYWGOmCgp3s7REtpWGA5ri4WQ5cevqntiafyGRX0nQLvH0u+lWVwn6AnW kPZPDqLIPhAsW6uRliIpbfHUPFYBd5yto0PMDEFH8Mn5JLqCv4Ufgfz7L2Mp0lJl9eM1 nuV9amVFCklF2a9xg0JXbQ443OSDRnJengTxm+khVtOx2QcY4PxfW1fGKGuqdazQD/aI K1L00uLiGDeNnwZminKrA/AQCXUuH6dCccU/4EfSRebvlgFBpyvG5Ybn0nbeb+KSU1gq KgXg== X-Gm-Message-State: APjAAAWZHDjl8zAqAuB1+f1ZgPT2xPTILKJP6iGQJDUS2gPbgcwXNEQY zs52O8lDLn5Ltg9qIlTkIDQzru/l+mE= X-Google-Smtp-Source: APXvYqy15oasgGL2ZUB4nRlMct+Cw1zwi2gfBNfpKcgS7n92PqPwvzAeFhcfoeMnDuTR7wdwh1ZNJg== X-Received: by 2002:ac2:5287:: with SMTP id q7mr30305944lfm.66.1577454633365; Fri, 27 Dec 2019 05:50:33 -0800 (PST) Original-Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id r21sm13623328ljn.64.2019.12.27.05.50.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Dec 2019 05:50:32 -0800 (PST) In-Reply-To: <878smyyt6o.fsf@cassou.me> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173817 Archived-At: On 27.12.2019 12:11, Damien Cassou wrote: > can you please tell what typo you are referring to? Also, when you say > "had" a typo, do you mean someone fixed it somewhere? Can you please > give a little more details? I can't find any fix. It's this one: commit 9ea9ac9a61067995a3f7a38f62766f32a8c38bb2 Author: Dmitry Gutov Date: Tue Dec 24 22:30:02 2019 +0200 Apply the 'xref-group' property properly * lisp/progmodes/xref.el (xref--insert-xrefs): Apply the 'xref-group' property properly (bug#36974). diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 8d8e7ab208..13a1600594 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -814,7 +814,7 @@ xref--insert-xrefs for line-format = (and max-line-width (format "%%%dd: " max-line-width)) do - (xref--insert-propertized '(face xref-file-header 'xref-group t) + (xref--insert-propertized '(face xref-file-header xref-group t) group "\n") (cl-loop for (xref . more2) on xrefs do (with-slots (summary location) xref >> Considering it's been applied 4 months ago and nobody noticed the >> problem, maybe it's not that useful after all? > > > I haven't switched to Emacs 27 yet. I hope you were going to do that before the release.