all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Damien Cassou <damien@cassou.me>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: 36974@debbugs.gnu.org
Subject: bug#36974: 26.2.90; [PATCH] Add imenu support to xref
Date: Fri, 27 Dec 2019 16:50:31 +0300	[thread overview]
Message-ID: <d5843379-bb11-97d8-2f1a-3cd9d3828686@yandex.ru> (raw)
In-Reply-To: <878smyyt6o.fsf@cassou.me>

On 27.12.2019 12:11, Damien Cassou wrote:
> can you please tell what typo you are referring to? Also, when you say
> "had" a typo, do you mean someone fixed it somewhere? Can you please
> give a little more details? I can't find any fix.

It's this one:

commit 9ea9ac9a61067995a3f7a38f62766f32a8c38bb2
Author: Dmitry Gutov <dgutov@yandex.ru>
Date:   Tue Dec 24 22:30:02 2019 +0200

     Apply the 'xref-group' property properly

     * lisp/progmodes/xref.el (xref--insert-xrefs):
     Apply the 'xref-group' property properly (bug#36974).

diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index 8d8e7ab208..13a1600594 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -814,7 +814,7 @@ xref--insert-xrefs
             for line-format = (and max-line-width
                                    (format "%%%dd: " max-line-width))
             do
-           (xref--insert-propertized '(face xref-file-header 'xref-group t)
+           (xref--insert-propertized '(face xref-file-header xref-group t)
                                       group "\n")
             (cl-loop for (xref . more2) on xrefs do
                      (with-slots (summary location) xref

>> Considering it's been applied 4 months ago and nobody noticed the
>> problem, maybe it's not that useful after all?
> 
> 
> I haven't switched to Emacs 27 yet.

I hope you were going to do that before the release.





  reply	other threads:[~2019-12-27 13:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08 11:53 bug#36974: 26.2.90; [PATCH] Add imenu support to xref Damien Cassou
2019-08-23  4:32 ` Lars Ingebrigtsen
2019-12-24 20:41   ` Dmitry Gutov
2019-12-25 16:17     ` Lars Ingebrigtsen
2019-12-25 16:29       ` Dmitry Gutov
2019-12-25 16:43         ` Dmitry Gutov
2019-12-25 17:10           ` Lars Ingebrigtsen
2019-12-27 10:11     ` Damien Cassou
2019-12-27 13:50       ` Dmitry Gutov [this message]
2019-12-27 14:24         ` Damien Cassou
2019-12-27 14:32           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5843379-bb11-97d8-2f1a-3cd9d3828686@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=36974@debbugs.gnu.org \
    --cc=damien@cassou.me \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.