From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Commit 57c74793c46c6533b63836f00aecaf3ac2accb6d probably needs to be reverted Date: Fri, 15 Mar 2019 18:32:25 -0700 Organization: UCLA Computer Science Department Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------C8CD9D044B698BB09CC8F3CA" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="257896"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 To: Philipp Stephani , Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 16 02:39:38 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h4yIT-001509-Mx for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 02:39:37 +0100 Original-Received: from localhost ([127.0.0.1]:35441 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4yIS-0003ve-FG for ged-emacs-devel@m.gmane.org; Fri, 15 Mar 2019 21:39:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4yBa-0008Ec-EF for emacs-devel@gnu.org; Fri, 15 Mar 2019 21:32:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4yBZ-0001rl-NP for emacs-devel@gnu.org; Fri, 15 Mar 2019 21:32:30 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:55968) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h4yBZ-0001rP-3C for emacs-devel@gnu.org; Fri, 15 Mar 2019 21:32:29 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CB5F516150D; Fri, 15 Mar 2019 18:32:26 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ZnxG7r5RhfaO; Fri, 15 Mar 2019 18:32:26 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0F607161584; Fri, 15 Mar 2019 18:32:26 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KUBDqnlS8zuJ; Fri, 15 Mar 2019 18:32:25 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E480F161420; Fri, 15 Mar 2019 18:32:25 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234194 Archived-At: This is a multi-part message in MIME format. --------------C8CD9D044B698BB09CC8F3CA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 3/14/19 5:49 AM, Philipp Stephani wrote: > Flymake is in Elpa and is supposed to be compatible with Emacs 26.1. > Commit 57c74793c46c6533b63836f00aecaf3ac2accb6d introduces an > incompatibility and should probably be reverted. > > Thanks, Sure, I installed the attached. --------------C8CD9D044B698BB09CC8F3CA Content-Type: text/x-patch; name="0001-Bring-back-Emacs-26-compatibility-to-flymake.el.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Bring-back-Emacs-26-compatibility-to-flymake.el.patch" >From fe97ca111d153a67c83058e6b742d7ca704e6189 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 15 Mar 2019 18:31:31 -0700 Subject: [PATCH] Bring back Emacs 26 compatibility to flymake.el * lisp/progmodes/flymake.el (flymake--schedule-timer-maybe): Revert to using seconds-to-time, since this file is part of ELPA and needs to work on Emacs 26 too. --- lisp/progmodes/flymake.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 7afcf7891d..830d700963 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -1005,7 +1005,9 @@ flymake--schedule-timer-maybe (setq flymake-timer (run-with-idle-timer - (encode-time flymake-no-changes-timeout) + ;; This can use encode-time instead of seconds-to-time, + ;; once we can assume Emacs 27 or later. + (seconds-to-time flymake-no-changes-timeout) nil (lambda (buffer) (when (buffer-live-p buffer) -- 2.20.1 --------------C8CD9D044B698BB09CC8F3CA--