From: Paul Eggert <eggert@cs.ucla.edu>
To: Philipp Stephani <p.stephani2@gmail.com>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: Commit 57c74793c46c6533b63836f00aecaf3ac2accb6d probably needs to be reverted
Date: Fri, 15 Mar 2019 18:32:25 -0700 [thread overview]
Message-ID: <d58203ce-8b0c-69c9-2d0b-9a9e4547cb01@cs.ucla.edu> (raw)
In-Reply-To: <CAArVCkTxBpbbeLFfQ6kZyj-EnbOux4aTiUWJexGtgbkTrUT+aQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 276 bytes --]
On 3/14/19 5:49 AM, Philipp Stephani wrote:
> Flymake is in Elpa and is supposed to be compatible with Emacs 26.1.
> Commit 57c74793c46c6533b63836f00aecaf3ac2accb6d introduces an
> incompatibility and should probably be reverted.
>
> Thanks,
Sure, I installed the attached.
[-- Attachment #2: 0001-Bring-back-Emacs-26-compatibility-to-flymake.el.patch --]
[-- Type: text/x-patch, Size: 1037 bytes --]
From fe97ca111d153a67c83058e6b742d7ca704e6189 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 15 Mar 2019 18:31:31 -0700
Subject: [PATCH] Bring back Emacs 26 compatibility to flymake.el
* lisp/progmodes/flymake.el (flymake--schedule-timer-maybe):
Revert to using seconds-to-time, since this file is part
of ELPA and needs to work on Emacs 26 too.
---
lisp/progmodes/flymake.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 7afcf7891d..830d700963 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1005,7 +1005,9 @@ flymake--schedule-timer-maybe
(setq
flymake-timer
(run-with-idle-timer
- (encode-time flymake-no-changes-timeout)
+ ;; This can use encode-time instead of seconds-to-time,
+ ;; once we can assume Emacs 27 or later.
+ (seconds-to-time flymake-no-changes-timeout)
nil
(lambda (buffer)
(when (buffer-live-p buffer)
--
2.20.1
next prev parent reply other threads:[~2019-03-16 1:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 12:49 Commit 57c74793c46c6533b63836f00aecaf3ac2accb6d probably needs to be reverted Philipp Stephani
2019-03-16 1:32 ` Paul Eggert [this message]
2019-03-16 15:53 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d58203ce-8b0c-69c9-2d0b-9a9e4547cb01@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.