all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Gregory Heytings <gregory@heytings.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: emacs.pdmp not always rebuilt
Date: Sun, 03 Oct 2021 23:27:51 +0000	[thread overview]
Message-ID: <d54fc4b7d2b14cabf5fd@heytings.org> (raw)
In-Reply-To: <878rzaqilg.fsf@gnus.org>

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]


>
> And it depends on the error.  Put the following into simple.el, and 
> you'll get a warning from the byte compiler, but you won't get any 
> errors when building:
>

This is because of dcf9cd47ae.  Patch attached, which will hopefully fix 
the other silent failures you experience.

[-- Attachment #2: Type: text/x-diff, Size: 1109 bytes --]

From dac10e81b344483b61ac4086725909a85be67ad2 Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Sun, 3 Oct 2021 23:21:32 +0000
Subject: [PATCH] Do not use the Elisp version of substitute-command-keys in
 batch mode.

src/print.c (print_error_message): Do not use the Elisp version of
substitute-command-keys in batch mode.
---
 src/print.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/print.c b/src/print.c
index d4301fd7b6..f83e5d9ece 100644
--- a/src/print.c
+++ b/src/print.c
@@ -941,7 +941,10 @@ print_error_message (Lisp_Object data, Lisp_Object stream, const char *context,
   else
     {
       Lisp_Object error_conditions = Fget (errname, Qerror_conditions);
-      errmsg = call1 (Qsubstitute_command_keys, Fget (errname, Qerror_message));
+      if (noninteractive)
+	errmsg = Fsubstitute_command_keys_old (Fget (errname, Qerror_message));
+      else
+	errmsg = call1 (Qsubstitute_command_keys, Fget (errname, Qerror_message));
       file_error = Fmemq (Qfile_error, error_conditions);
     }
 
-- 
2.33.0


  reply	other threads:[~2021-10-03 23:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-03 12:41 emacs.pdmp not always rebuilt Lars Ingebrigtsen
2021-10-03 12:53 ` Eli Zaretskii
2021-10-03 13:10   ` Lars Ingebrigtsen
2021-10-03 14:35     ` Stefan Monnier
2021-10-03 14:38       ` Lars Ingebrigtsen
2021-10-03 23:27         ` Gregory Heytings [this message]
2021-10-04  0:45           ` Stefan Kangas
2021-10-04  2:28           ` Eli Zaretskii
2021-10-04  8:57             ` Gregory Heytings
2021-10-04  9:19               ` Lars Ingebrigtsen
2021-10-04 11:14                 ` Stefan Kangas
2021-10-04 12:53                 ` Eli Zaretskii
2021-10-04 12:50               ` Eli Zaretskii
2021-10-04 13:05                 ` Gregory Heytings
2021-10-04 13:25                   ` Gregory Heytings
2021-10-04 13:37                     ` Eli Zaretskii
2021-10-04 14:18                       ` Gregory Heytings
2021-10-04 14:34                         ` Eli Zaretskii
2021-10-04 16:02                           ` Gregory Heytings
2021-10-04 16:56                             ` Eli Zaretskii
2021-10-04 13:30                   ` Eli Zaretskii
2021-10-04 14:03                     ` Stefan Kangas
2021-10-04 14:19                       ` Gregory Heytings
2021-10-04 15:10                         ` Eli Zaretskii
2021-10-03 14:52     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d54fc4b7d2b14cabf5fd@heytings.org \
    --to=gregory@heytings.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.