From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#354: "Added (how many lines, bytes?!) to file.txt" Date: Sun, 2 Apr 2017 11:24:30 -0700 Organization: UCLA Computer Science Department Message-ID: References: <54F01AE2.8050406@cs.ucla.edu> <87y4njzckz.fsf@gmail.com> <87fuig7jxo.fsf@users.sourceforge.net> <83h92vc0op.fsf@gnu.org> <87mvc021mr.fsf@users.sourceforge.net> <83zig04q2n.fsf@gnu.org> <87shlrxy2e.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1491157516 16759 195.159.176.226 (2 Apr 2017 18:25:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Apr 2017 18:25:16 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 Cc: 354@debbugs.gnu.org, kb1vqh@gmail.com To: npostavs@users.sourceforge.net, Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 02 20:25:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cukBZ-0003Ma-7R for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Apr 2017 20:25:09 +0200 Original-Received: from localhost ([::1]:55891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cukBb-0007b7-S1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Apr 2017 14:25:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cukBV-0007Za-My for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2017 14:25:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cukBS-0004bF-Il for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2017 14:25:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59533) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cukBS-0004bB-G3 for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2017 14:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cukBS-0002Z8-9m for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2017 14:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Apr 2017 18:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 354 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 354-submit@debbugs.gnu.org id=B354.14911574799817 (code B ref 354); Sun, 02 Apr 2017 18:25:02 +0000 Original-Received: (at 354) by debbugs.gnu.org; 2 Apr 2017 18:24:39 +0000 Original-Received: from localhost ([127.0.0.1]:57729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cukB5-0002YG-3S for submit@debbugs.gnu.org; Sun, 02 Apr 2017 14:24:39 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:53502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cukB3-0002Xw-3L for 354@debbugs.gnu.org; Sun, 02 Apr 2017 14:24:37 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2A9331600EA; Sun, 2 Apr 2017 11:24:31 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id dFyKduycYYX2; Sun, 2 Apr 2017 11:24:30 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 892B11600DD; Sun, 2 Apr 2017 11:24:30 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id L-NfTMj4Ww30; Sun, 2 Apr 2017 11:24:30 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6B78C1600B3; Sun, 2 Apr 2017 11:24:30 -0700 (PDT) In-Reply-To: <87shlrxy2e.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131225 Archived-At: On 04/01/2017 08:55 PM, npostavs@users.sourceforge.net wrote: > + (build_string ("%s %d characters of `%s'"), > + build_string (NUMBERP (append) ? "Updated" > + : ! NILP (append) ? "Added" > + : "Wrote"), This should use AUTO_STRING instead of build_string. Also, follow the old code and use just one string (a format) instead of two, as it's more important to use idiomatic English than to save a few bytes in the Emacs executable.