From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Reformat all of src/ Date: Wed, 28 Dec 2016 10:38:17 -0800 Organization: UCLA Computer Science Department Message-ID: References: <87h95olvg0.fsf@gmail.com> <228ccc55affe1320a030a5652c63e005.squirrel@cloud103.planethippo.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1482950314 24256 195.159.176.226 (28 Dec 2016 18:38:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Dec 2016 18:38:34 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 To: Phillip Lord , Chris Gregory , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 28 19:38:30 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cMJ7N-0005jG-7N for ged-emacs-devel@m.gmane.org; Wed, 28 Dec 2016 19:38:29 +0100 Original-Received: from localhost ([::1]:60472 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMJ7S-0003eV-5I for ged-emacs-devel@m.gmane.org; Wed, 28 Dec 2016 13:38:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMJ7L-0003eE-Ax for emacs-devel@gnu.org; Wed, 28 Dec 2016 13:38:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cMJ7I-00005o-0X for emacs-devel@gnu.org; Wed, 28 Dec 2016 13:38:27 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:36090) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cMJ7H-00005Y-QI for emacs-devel@gnu.org; Wed, 28 Dec 2016 13:38:23 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8F7B71600FB; Wed, 28 Dec 2016 10:38:21 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id EsYSsfxQQSAm; Wed, 28 Dec 2016 10:38:20 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D5AE11600FC; Wed, 28 Dec 2016 10:38:20 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id oyA4xQpT_IRU; Wed, 28 Dec 2016 10:38:20 -0800 (PST) Original-Received: from [192.168.1.9] (unknown [47.153.178.162]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id B77721600FB; Wed, 28 Dec 2016 10:38:20 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210923 Archived-At: Phillip Lord wrote: > The commit hook already checks for some whitespace issues (spaces befor= e > tabs for instance). That it checks for spaces-for-tabs is mostly an accident. I added 'git=20 diff-index --check' to the pre-commit hook mostly to catch white space at= line=20 end, which can be a real problem due to languages like C and Elisp where = such=20 white space (typically invisible) can quietly change the semantics of a p= rogram. Althoug the --check option also happens to look for space-before-tab in i= nitial=20 indent, this is not a significant problem in practice for us and we could= easily=20 remove that part of the check if we want. I haven't worried about it, tho= ugh,=20 because (like Stefan) I view this tab-vs-spaces thing as a waste of time.= I=20 don't even like the indent-tabs-mode thing that we default to in elisp co= de, as=20 it's one more thing to worry about in an area where we should not be worr= ying.