From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id /nn6BWxtRmGBgwEAgWs5BA (envelope-from ) for ; Sun, 19 Sep 2021 00:51:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4pUpAWxtRmHiWQAA1q6Kng (envelope-from ) for ; Sat, 18 Sep 2021 22:51:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9DF1889E9 for ; Sun, 19 Sep 2021 00:51:23 +0200 (CEST) Received: from localhost ([::1]:56080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRjB3-0006o2-9X for larch@yhetil.org; Sat, 18 Sep 2021 18:51:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRj7I-0006ea-JW for emacs-orgmode@gnu.org; Sat, 18 Sep 2021 18:47:28 -0400 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:46653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRj7G-0003cK-W7 for emacs-orgmode@gnu.org; Sat, 18 Sep 2021 18:47:28 -0400 Received: by mail-pg1-x52f.google.com with SMTP id m21so4235052pgu.13 for ; Sat, 18 Sep 2021 15:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=BnZm+TL1Suy8yNqDaeC+aywUMxrkXtT8sPCPEteO34Y=; b=j7aRSwrCg2NhG12nJlOmfCug7KmZ6Ptz1BkufVVhEKyO9yCUa30Rkqc0RPqjdF33bw hWBqcK4BCO9BCYyE6SmiY9nAaV0TIf/buUbrFJ3SGatSZN+t9vj2bQG10BVJPVd3bpBr TnpRttB+LyRV4TWyDGhHPSOTKths+mxnQ4sc8W7d392EXPcCeddqtHHQS3c8M04LAgMY RVBDQXQZEayiTgaeJh7+rnELLGo6XGPvsOW8w6eahi4lRmQJQEehOHoUyyMEUNwG95Kj bVBQ8+4CFiQUbIhjxkSAkS4YPh/YiuU5Mk5yAe+0jRdxQ34J08xKGP9RLoeY1lBYHju/ 1vzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BnZm+TL1Suy8yNqDaeC+aywUMxrkXtT8sPCPEteO34Y=; b=KGeE7gDgsdbjh2WjWX4hH1PdROc9oXT1BmH6RUQoG1StN+7iNSwNB4kGEAU79CDY4F EvhYSiSvrsJNQHzD8S7gc7/UVuprQ6y5ms0F4ceGCBwct7kNfn5K2nLvcJBGe0OkNiJ1 gbdhO64HBKkMLYfKCzKl/yEaeB9a7RMmfQHS47gY+f16XUE0AwhrZ7BOFTkfwx+38o8S nQDltNiOUsmv9cbTvkmgBXF3MOcZV9NQNYSfmYzz5QhZhMqUkO5wzU4HYZfbNet2kKLY MSLtbZo/rlNzgw3bFEKnlrCZIiTRLbE1ZJ6EU0WFry17Fni9sm93E1PRoKZuUr+5aXME oZgQ== X-Gm-Message-State: AOAM533vz4YrCtzyR+/4e5HIUD7jKqCg/OSHLioFWxWcVTuEZnuDjBsB 3UOg+Ne2q2ga+G+HWon1vj4J3udEeB8= X-Google-Smtp-Source: ABdhPJzZIOJyVj3EFFpJoy13qfS2NyFhxQMaqozVWfePZrRKhi1iOoog7LESOEP6FhENofRUqHDIlA== X-Received: by 2002:a65:41c6:: with SMTP id b6mr16575031pgq.206.1632005245525; Sat, 18 Sep 2021 15:47:25 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x22sm9830783pfm.102.2021.09.18.15.47.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Sep 2021 15:47:25 -0700 (PDT) Subject: Re: [PATCH] Improve org-mouse support for checkboxes To: Samuel Wales References: From: Jim Porter Message-ID: Date: Sat, 18 Sep 2021 15:47:24 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=jporterbugs@gmail.com; helo=mail-pg1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 18 Sep 2021 18:50:15 -0400 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632005483; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=BnZm+TL1Suy8yNqDaeC+aywUMxrkXtT8sPCPEteO34Y=; b=vBg+k2fOfYOKHgR/D+1PkNk3aXJ+cdOVK7zFyBbBr5bE+Idq9FE3ZOS6ZSqh/QYxpX4htx VfIx5wSm3XkIPQotw3s4CTFIfPs0YCOL7dktxN0yqqSSiVJT8KFxP+oMDYgJB/2T70M2RM XSPrvWKmqYokr/oDXU8q8Uw9WjmHRyqRAIfbABzulutReYlZmhs2devtlX4AHGWETmfnkH qhKuAzaYinSbhLS+HshCny0poYJzQ9XBbhPA0dBLhO4VhfpKeSbBkrAufzOyp6QI9VsoBD 2tEa1yMmnZPSWCSsjaMW6NbUTnMtHJPY+qfhrQHylOSE6WBNkAhd8Tyqhj8oOw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632005483; a=rsa-sha256; cv=none; b=MJeh16aMr68GHjDuiHuUVtmNiC+qe1tY2mnX6TaoEw/wGszmMatj1y6pwSo91px0RZ56It Bw6GBE/vkVLMxS3T/21WHZzpixmKCImmvVr4jHV5EGzBNEoH35alQXNYtdGwkMaKXVT8NC 7EoUNbp4TDh27CLnvVdi0fDXw6Jd0Z0H5Q8XbyinVwAJ32c4XDlX8cOOxsml0pmiok5yEY qPDavL7wkPWUcKomGeYN6vZV1Xl3K06SUB6fgMiC4vljSvheb1Xv7UA7Oz0mEQH8t5h8pT kBtsOgbV81999KrvzTwbvGcIIgy1oTpr+9soYsXMVZuBpBsUYEoeVYPwCHozsw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=j7aRSwrC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.09 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=j7aRSwrC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 9DF1889E9 X-Spam-Score: -3.09 X-Migadu-Scanner: scn0.migadu.com X-TUID: c3FSn4b28cW2 On 9/18/2021 1:54 PM, Samuel Wales wrote: > thanks for this. if tests are written, might be useful to include the > case where half-checked are parents. I tested manually, and this behaves how I'd expect; not surprising, since it just calls `org-toggle-checkbox'. Maybe there's an argument that parent checkboxes shouldn't be clickable in the first place though. I don't think you can call `org-toggle-checkbox' on parent checkboxes (or if you can, I'm not sure what the trick is). My patch doesn't change that though, aside from having half-checked boxes be clickable in general. I could look into writing some automated tests for this, but I don't see any existing ones for org-mouse, and I'm not familiar with simulating mouse events for Emacs tests.