From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Steve Yegge Newsgroups: gmane.emacs.bugs Subject: bug#4130: issues with js2-mode faces Date: Tue, 11 Aug 2009 22:50:59 -0700 Message-ID: References: <200908091800.n79I0KLn016605@godzilla.ics.uci.edu> Reply-To: Steve Yegge , 4130@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=0016e64755c25339910470eb678a X-Trace: ger.gmane.org 1250080641 20480 80.91.229.12 (12 Aug 2009 12:37:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Aug 2009 12:37:21 +0000 (UTC) Cc: bug-gnu-emacs To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 12 14:37:14 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MbD4r-0008Gd-Q3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Aug 2009 14:37:14 +0200 Original-Received: from localhost ([127.0.0.1]:37025 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MbD4m-0002f1-UE for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Aug 2009 08:37:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mb6zC-0006Kv-68 for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 02:06:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mb6z7-0006Kj-Aq for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 02:06:57 -0400 Original-Received: from [199.232.76.173] (port=47788 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mb6z7-0006Kg-5I for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 02:06:53 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:33642) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mb6z6-00024L-J2 for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 02:06:52 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7C66mr0030154; Tue, 11 Aug 2009 23:06:49 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7C6047p028321; Tue, 11 Aug 2009 23:00:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Steve Yegge Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 12 Aug 2009 06:00:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 4130 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125005627027088 (code B ref -1); Wed, 12 Aug 2009 06:00:03 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 12 Aug 2009 05:51:10 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7C5p8kZ027085 for ; Tue, 11 Aug 2009 22:51:09 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mb6js-0001wZ-2Q for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 01:51:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mb6jn-0001te-MQ for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 01:51:07 -0400 Original-Received: from [199.232.76.173] (port=55485 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mb6jn-0001tO-C4 for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 01:51:03 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:53522) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mb6jm-00088e-LJ for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 01:51:02 -0400 Original-Received: from mail-vw0-f182.google.com ([209.85.212.182]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mb6jl-0007Ix-BW for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 01:51:01 -0400 Original-Received: by vws12 with SMTP id 12so4107341vws.24 for ; Tue, 11 Aug 2009 22:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=A98D+0iokscCeMvuy+svhxDKTzJSkfMPMOBQ6nAZhiU=; b=EEGQwfwBfLvgxK825jEd0hvikjQC5/zIUOuZdjWYdaGg0pzVDg4lwLLJSKZrKq4JhC ikQUK6d9GKIl1HmIq/e+R70NPbS62UgXpUgEUj7MuTphr6oG7fxZ7xANZZHJNg8sAyWH XOfXnt1EoTl2KoSe8XsnfXdk9TWOErs1BjFJ8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=lKMjdALGoAQ8PeyruRHWUA/1KHyG8038HrRgBgAXcpldRQgzyurR3iSZoAL9RulI39 7VSsYMccOqFq/vTw6aOE4evkK4CNL9Fbg3PeIZwNrDndB0SbbAj4lPs+ELJvvC7ocw8S rLdJ3poeNKsjfXn4dOwKOxgeQnfrmHWxmpu7k= Original-Received: by 10.220.90.194 with SMTP id j2mr191070vcm.70.1250056259975; Tue, 11 Aug 2009 22:50:59 -0700 (PDT) In-Reply-To: <200908091800.n79I0KLn016605@godzilla.ics.uci.edu> X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Wed, 12 Aug 2009 02:06:57 -0400 X-Mailman-Approved-At: Wed, 12 Aug 2009 08:36:14 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30126 Archived-At: --0016e64755c25339910470eb678a Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On Sun, Aug 9, 2009 at 11:00 AM, Dan Nicolaescu wrote: > > js2-mode uses -face suffix for faces. > > We are not using this suffix anymore and the tree has been cleaned up of > such with backward compatibility code added. This is new code, so > there's little point in having the suffix... > Agree; I'll fix it. The docs (info pages) are incorrect on a relevant point, incidentally; they claim that defining variables whose value is set to the face of the same name is popular but obsolete; the reality is that font-lock-add-keywords requires the variable definitions. > > Also, instead of defining a new js2-error-face why not just use > font-lock-warning-face? > Why not just define a font-lock-error-face instead? Other modes (such as compilation) define their own error faces. Fix it in Emacs and the modes will follow. -steve --0016e64755c25339910470eb678a Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Sun, Aug 9, 2009 at 11:00 AM, Dan Nicolaescu <dann@ics.uci.edu> wrote:

js2-mode uses -face suffix for faces.

We are not using this suffix anymore and the tree has been cleaned up of such with backward compatibility code added. =A0This is new code, so
there's little point in having the suffix...

Agree; I'll fix it. =A0The docs (info = pages) are incorrect on a relevant point,
incidentally; they clai= m that defining variables whose value is set to the
face of the s= ame name is popular but obsolete; the reality is that
font-lock-add-keywords requires the variable definitions.
= =A0

Also, instead of defining a new js2-error-face why not just use
font-lock-warning-face?

Why not just define a font-lock-error-face inst= ead?=A0=A0Other=A0modes
(such=A0as=A0compilation)=A0define=A0thei= r=A0own=A0error=A0faces.=A0=A0Fix=A0it=A0in=A0Emacs
and=A0the=A0m= odes=A0will=A0follow.

-steve
--0016e64755c25339910470eb678a--