From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Romanos Skiadas Newsgroups: gmane.emacs.bugs Subject: bug#25717: 25.1.1; "erc-button-google-url" should not refer to a specific search engine Date: Sat, 14 Apr 2018 19:41:20 +0100 Message-ID: References: <87inod1jkj.fsf@andrewrobbins.info> <87a7u54p1o.fsf@mouse.gnus.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------9D21ED1F036406EE960A46E0" X-Trace: blaine.gmane.org 1523731211 16604 195.159.176.226 (14 Apr 2018 18:40:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Apr 2018 18:40:11 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 Cc: 25717@debbugs.gnu.org To: Lars Ingebrigtsen , Andrew Robbins Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 14 20:40:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7Q5n-0004By-9h for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Apr 2018 20:40:07 +0200 Original-Received: from localhost ([::1]:56021 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7Q7s-0000vc-1C for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Apr 2018 14:42:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7Q7j-0000uo-11 for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 14:42:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7Q7e-0000cr-4l for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 14:42:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44726) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f7Q7d-0000cb-Tb for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 14:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f7Q7d-0007lr-MY for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 14:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Romanos Skiadas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Apr 2018 18:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25717 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 25717-submit@debbugs.gnu.org id=B25717.152373129029831 (code B ref 25717); Sat, 14 Apr 2018 18:42:01 +0000 Original-Received: (at 25717) by debbugs.gnu.org; 14 Apr 2018 18:41:30 +0000 Original-Received: from localhost ([127.0.0.1]:52623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7Q78-0007l4-1f for submit@debbugs.gnu.org; Sat, 14 Apr 2018 14:41:30 -0400 Original-Received: from mail-wr0-f169.google.com ([209.85.128.169]:39807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7Q75-0007kp-Uk for 25717@debbugs.gnu.org; Sat, 14 Apr 2018 14:41:28 -0400 Original-Received: by mail-wr0-f169.google.com with SMTP id q6so3633328wrd.6 for <25717@debbugs.gnu.org>; Sat, 14 Apr 2018 11:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=9ExMuCQGmV5ay6ZPHZD14PG0Zom21Y0yCbrSe0rrEBg=; b=QSoHFaktBkchZx1FpvBQJxfgmgdeIWs7JoUOfz59OaetIXrSKir16Lh+B8tyE3FGow 769UCUUQc0XAizTSamghOrnZy55nA0avVp+mkOlA1f2KNleGoXYu4dWOK6/wpidTGsfh zTaXue9O9RJfJPqtM0kWYDfWzIhtiGYWLwhnXOmMx6LygYjakSbv8gA1cxYoqwxpGdhm DslAclEZDo2weFbG7NfryYnt1r24ABS7WsKksUDn+E8eNsQcRFBl2gH061rQeCtv9PFF uJE74x2HS3/gXXBTVTlWEqxARcCXHZx6Txul27vDjpwAiQJ8YkfpxKsveyR0fgG/DpBU OX/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=9ExMuCQGmV5ay6ZPHZD14PG0Zom21Y0yCbrSe0rrEBg=; b=iS2+72AwUQkcBP7RlntpMBUG+mAprOYO0rzm6FVK4chSv162/oklXl/yaiUQARsf1d w/cdcNuamA21U8CG8fvAaSDzf1e9rSHw/dK/38CJ8L01diOuu91NLMmI/zc3IkUZwbAE ugflSBFC17LkZePEosCCegyYK6Ip/YN5yYDCti3pgdUdFIfwF3cnM1hMw5EU7gB2GGnV f/gPzrok/nb0TKGXYMt+fXywnr4cliSFbQiVZYFwyas8Y8yLX+txrjV7SUbK2OTtpar1 OFa3NkNr0AKXoVskE11yFl9bEoh1bzmGXGAVtMfrgDuPv1KWEPOgYWEK0B5449phePnR n5xQ== X-Gm-Message-State: ALQs6tBHWyXPHyGPeU5a5z8ItaWOkdo6v7JVrZVYvbhLG34fmeXlBTIs y0RgvaNuguc9ZNpIRLB5svW2urVt X-Google-Smtp-Source: AIpwx49CzA7rARCfjhbJiuVKFuI05NQGd7WfK84eqIXQUU6oYbSPD8R4W4HeKTcMtGcfnZk2YdKmOg== X-Received: by 10.80.232.136 with SMTP id f8mr5974953edn.8.1523731281877; Sat, 14 Apr 2018 11:41:21 -0700 (PDT) Original-Received: from [192.168.1.4] ([109.78.13.197]) by smtp.gmail.com with ESMTPSA id b36sm4688446edd.81.2018.04.14.11.41.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Apr 2018 11:41:21 -0700 (PDT) In-Reply-To: <87a7u54p1o.fsf@mouse.gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145357 Archived-At: This is a multi-part message in MIME format. --------------9D21ED1F036406EE960A46E0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 14/04/18 19:32, Lars Ingebrigtsen wrote: > Andrew Robbins writes: > >> The ERC variable "erc-button-google-url" should not refer to a >> specific search engine in its name and certainly not a >> privacy-disrespecting one at that in a GNU program[1]. >> >> I would suggest renaming the variable to something more generic >> such as "erc-button-web-search-url" or "erc-button-search-url" >> and changing the default value from >> "http://www.google.com/search?q=%s" to any of the following (or >> similar) at the developers' preference: >> >> * "http://duckduckgo.com/?q=%s" > This is now fixed in Emacs 27.1. > Looks like the docstring needs to change as well (emphasis mine): -(defcustom·erc-button-google-url "http://www.google.com/search?q=%s" +(defcustom·erc-button-search-url "http://duckduckgo.com/?q=%s" · "URL used to browse *Google* search references. %s·is replaced by the search string." +· :version "27.1" --------------9D21ED1F036406EE960A46E0 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit



On 14/04/18 19:32, Lars Ingebrigtsen wrote:
Andrew Robbins <contact@andrewrobbins.info> writes:


The ERC variable "erc-button-google-url" should not refer to a
specific search engine in its name and certainly not a
privacy-disrespecting one at that in a GNU program[1].

I would suggest renaming the variable to something more generic
such as "erc-button-web-search-url" or "erc-button-search-url"
and changing the default value from
"http://www.google.com/search?q=%s" to any of the following (or
similar) at the developers' preference:

* "http://duckduckgo.com/?q=%s"

This is now fixed in Emacs 27.1.
Looks like the docstring needs to change as well (emphasis mine):
-(defcustom·erc-button-google-url "http://www.google.com/search?q=%s" 
+(defcustom·erc-button-search-url "http://duckduckgo.com/?q=%s" 
 · "URL used to browse Google search references. 
 %s·is replaced by the search string." 
+· :version "27.1"
--------------9D21ED1F036406EE960A46E0--