From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 14 Nov 2019 16:14:16 +0200 Message-ID: References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <83blte7kvc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="195446"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 37774@debbugs.gnu.org To: Eli Zaretskii , Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 14 15:15:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVFu7-000od6-NZ for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Nov 2019 15:15:23 +0100 Original-Received: from localhost ([::1]:58134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVFu6-0004vy-EN for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Nov 2019 09:15:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42695) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVFtn-0004sS-M2 for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 09:15:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVFtm-0004bV-Hj for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 09:15:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVFtm-0004bP-EB for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 09:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVFtm-0000Uj-9T for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 09:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Nov 2019 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15737408681833 (code B ref 37774); Thu, 14 Nov 2019 14:15:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 14 Nov 2019 14:14:28 +0000 Original-Received: from localhost ([127.0.0.1]:32923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVFtE-0000TV-HY for submit@debbugs.gnu.org; Thu, 14 Nov 2019 09:14:28 -0500 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:38652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVFtB-0000TD-GP for 37774@debbugs.gnu.org; Thu, 14 Nov 2019 09:14:27 -0500 Original-Received: by mail-wm1-f54.google.com with SMTP id z19so6074047wmk.3 for <37774@debbugs.gnu.org>; Thu, 14 Nov 2019 06:14:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7oQctVDMf++n3TcAyCzlnafHqTJFAxaCwkDkRKA2P4s=; b=Mcjk7JJnDB0PpAC1MEE98dYH5NaDEm3aUhWpKjQIn9iNdwj/dyN2t0BfNlOqHqq9oR MJ8flVWiL638EUJRjJDCIqjcoaynmccFnFJje4MFsPGIOfsqpDotd0VKdbZOL2r15hM/ auYzjqC8vT7Uwclb/ObGbx2xd/ZSWQo31VFwNolZoX9LpaL5K+Ar660qGY27GP8ttMzE XAmlVzpc3YLbgPQZAIegZsydjC4lG3BWeR2zx3XmucrPlxYz6WKq+7JRwrcxN7FK+5Uy luGNth0DtRUbYMJqtz5gSEQmfMG1+2J2ZrUCdPaXEpPSKuCDnL4k5kDqIiKxkh0dDtxP ld9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7oQctVDMf++n3TcAyCzlnafHqTJFAxaCwkDkRKA2P4s=; b=YPECPuISUZH6QYKZMRjqOofarbt6cKM+/f/no8RDdoEzb1Mf4a82jZcwZNgLhZ8cpG smHKn+9jqzkjMt8EF6GYcC266x8dq38gNJZ8K+qzV6XuZ/lktzAutAmxx335/jaLGlaW in6q+KTlv6v+Prj3Chx2TYGH+meG/KbnxF7uUKq0pFNzzgZLj16M7lJE/M7LzlLRi7S4 TX6bu/9jFIcDEu/SeZRIC0lztT+M/V/6ci2Lc692WUaXJpo5ifbvu2o9H4tUxxmEUH2Z oenc5iz3DMIGzuehWdTXQP/SI7ewyvXmD7q5AuBAdw80sD7sKpNT2t4t39Mz8AB4KxCe A+vQ== X-Gm-Message-State: APjAAAX20/FPOCbTHmKeAvVPMqfqDXT8hXonoyYqQQKjaaohM0cWJ50M QD18DXQYrqVxLq76UFyB7SceAhnv5Yw= X-Google-Smtp-Source: APXvYqwDQRIedsdrR0KGkhIARNldpxRoFWnwTmA5MSTNW+eWeGVJB+tYyxfrEZeF4OOqbjiv8CZgow== X-Received: by 2002:a7b:cb09:: with SMTP id u9mr2692366wmj.28.1573740859366; Thu, 14 Nov 2019 06:14:19 -0800 (PST) Original-Received: from [192.168.0.149] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id z9sm7333328wrv.35.2019.11.14.06.14.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 06:14:17 -0800 (PST) In-Reply-To: <83blte7kvc.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171592 Archived-At: On 14.11.2019 13:33, Eli Zaretskii wrote: >> Should it be unnecessary that each and every theme does: >> - '(hl-line ((t (:background "lightgrey")))) >> + '(hl-line ((t (:background "lightgrey" :extend t)))) >> ? > How is :extend different from any other face attribute? > > The documentation of custom-theme-set-faces says that FACE should be a > face spec, like in defface. And the latter does override all the > attributes, unless it uses :inherit. > > So I'm not unsure why you expected something else. *I* expected that going by your messages here and here: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37774#104 https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37774#131 Had I been mistaken? Then the backward compatibility problem is going to be bigger than I thought. That's too bad. And my apologies to Jonas.