From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.help Subject: Re: Defadvice use Date: Mon, 18 Apr 2005 14:28:37 -0600 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1113856174 22832 80.91.229.2 (18 Apr 2005 20:29:34 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 18 Apr 2005 20:29:34 +0000 (UTC) Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Mon Apr 18 22:29:34 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DNcrV-0002bE-H3 for geh-help-gnu-emacs@m.gmane.org; Mon, 18 Apr 2005 22:28:53 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DNcvg-00057H-6s for geh-help-gnu-emacs@m.gmane.org; Mon, 18 Apr 2005 16:33:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DNcu5-0004k0-MJ for help-gnu-emacs@gnu.org; Mon, 18 Apr 2005 16:31:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DNcu3-0004jV-Oz for help-gnu-emacs@gnu.org; Mon, 18 Apr 2005 16:31:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DNcu3-0004QK-H5 for help-gnu-emacs@gnu.org; Mon, 18 Apr 2005 16:31:31 -0400 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1DNcvB-0003ja-JS for help-gnu-emacs@gnu.org; Mon, 18 Apr 2005 16:32:41 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1DNco1-00023r-9N for help-gnu-emacs@gnu.org; Mon, 18 Apr 2005 22:25:17 +0200 Original-Received: from 207.167.42.60 ([207.167.42.60]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 18 Apr 2005 22:25:17 +0200 Original-Received: from ihs_4664 by 207.167.42.60 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 18 Apr 2005 22:25:17 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: help-gnu-emacs@gnu.org Original-Lines: 40 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 207.167.42.60 User-Agent: Mozilla Thunderbird 0.9 (X11/20041105) X-Accept-Language: en-us, en In-Reply-To: X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:25792 X-Report-Spam: http://spam.gmane.org/gmane.emacs.help:25792 Matthias wrote: > I have the following problem: How do I advice a function so that > within that function, the function `read-minibuffer' (for example) > calls the definition of another function, say `my-read-minibuffer'? > > I'm trying to use an advice around the function; the advice providing > a binding of the symbol `read-minibuffer' to the definition of > `my-read-minibuffer'. Like the following: > > (defadvice la-fonction > (around la-fonction-extended enable compile) > "Documentation" > (let (f1) > (fset 'f1 read-minibuffer) > (fset 'read-minibuffer my-read-minibuffer) > ad-do-it > (fset 'read-minibuffer f1))) > > Any comment? Is it silly? Is there a better way? Any idea? Here's how I'd do it: (defvar la-fonction-read-minibuffer nil "If non-nil, the function to call instead of `read-minibuffer'.") (defadvice read-minibuffer (around la-fonction activate) "If `la-fonction-read-minibuffer' is non-nil, call it and return its result instead." (if la-fonction-read-minibuffer (apply la-fonction-read-minibuffer (ad-get-args 0)) ad-do-it)) (defadvice la-fonction (around read-minibuffer activate) "Temporarily bind `la-fonction-read-minibuffer' to `my-read-minibuffer'." (let ((la-fonction-read-minibuffer 'my-read-minibuffer)) ad-do-it)) -- Kevin Rodgers