From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#17871: 24.4.50; (elisp) `Core Advising Primitives': interactive spec as function? Date: Sun, 18 Aug 2019 17:35:15 -0700 (PDT) Message-ID: References: <400906ac-35f1-48e4-8df9-8e65b340209b@default> <87vbrjdajs.fsf@web.de> <82178260-247b-4653-85db-d6586480419e@default> <87d2dqdsyj.fsf@web.de> <8736ihb0ds.fsf@mouse.gnus.org> <87d0hl3xqx.fsf@web.de> <878ss99jhi.fsf@mouse.gnus.org> <87o914xh50.fsf@web.de> <87ftmgdl2d.fsf@mouse.gnus.org> <8736hy1wxt.fsf@web.de> <87ef1i38g4.fsf@gmail.com> <87k1ba3wgc.fsf@mouse.gnus.org> <877e7a2fut.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="125148"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Michael Heerdegen , Stefan Monnier , 17871@debbugs.gnu.org To: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 19 02:36:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hzVed-000WQw-JB for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Aug 2019 02:36:11 +0200 Original-Received: from localhost ([::1]:43870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzVeb-0004oj-HT for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Aug 2019 20:36:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59462) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzVeV-0004nD-5e for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 20:36:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzVeU-0001u3-32 for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 20:36:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50152) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzVeT-0001tr-V0 for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 20:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hzVeT-0000Qa-Q8 for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 20:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Aug 2019 00:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 17871-submit@debbugs.gnu.org id=B17871.15661749391616 (code B ref 17871); Mon, 19 Aug 2019 00:36:01 +0000 Original-Received: (at 17871) by debbugs.gnu.org; 19 Aug 2019 00:35:39 +0000 Original-Received: from localhost ([127.0.0.1]:58971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzVe6-0000Pp-5h for submit@debbugs.gnu.org; Sun, 18 Aug 2019 20:35:39 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:44848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzVe4-0000Pb-9c for 17871@debbugs.gnu.org; Sun, 18 Aug 2019 20:35:37 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7J0YSpf061479; Mon, 19 Aug 2019 00:35:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=2pmrl/LF/ZvlHeG198YxN8OM609qeErZzKmYUmWuylk=; b=SohktQVrtzkQHa6SiEUOiwHx9DjEsVh6l5NvNojcLQCeJZr8DfbOCHzyuYECR0UDDTrl ZZCCANPymXf3M6cIsoTA4Jy7Dt3CpqojzJjtF7YM2Vjm/vVxGSGzA65ZmpnQzYriD0sf V1/5ChuTPYXf8IT7ApnEdg8gYdofJAe4CPFPDl5VEx3c4wRopGAjeBC9bTHrkD+O2OJg Xi1G5aKbKRygnSdABZwl89nQBuaUiW3SaeHVLwa5lvNb3t8hOZoxzAN/YF9TtH2wECBQ tuzl22i4Fa4mh8SRHA3ilQ65VAZOobH8kcmulU/cT8MHt+zLdOlrWMHlqMCyZ0I5+1Nn wQ== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2uea7qc8f5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Aug 2019 00:35:30 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7J0Xm9G001051; Mon, 19 Aug 2019 00:35:29 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2ue6qdvjnt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Aug 2019 00:35:29 +0000 Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x7J0ZGBv019170; Mon, 19 Aug 2019 00:35:20 GMT In-Reply-To: <877e7a2fut.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4873.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9353 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908190002 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9353 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908190003 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165366 Archived-At: > >> (advice-add 'compose-mail :around #'my-compose-mail-advice) > > > > That's a good example. I've now added it to the trunk with some > > slight modifications. >=20 > Thanks (and let me use this opportunity to express sincere admiration > and gratitude for your general bug slaying performance and stamina). >=20 > If that really improves the substance of this bug report only Drew can > say I guess. >=20 > I for one still think that a more detailed explanation similar to > Michael's from a previous mail[1] would be helpful, ideally with more > examples. +1. The example will help, no doubt. But it would also help to explicitly point out that this use (for advice) of `interactive' is not the usual one. What Michael said here: Although we can with nadvice use the same syntax for defining pieces of advice as for defining functions, advices have a different meaning (semantic). The interactive specs of advices are not exactly interactive specs in the common sense - although they look similar, they are related, but different features. I think a short example would be good. Also, the term "function" is a bit unclear here, maybe we should add "a lambda expression or fbound symbol" or so, to make clear that we don't mean a sexp that returns a function. > And although I have managed to clarify a few points myself thanks to > this conversation, my personal conundrum[2] remains unanswered: why > does a simple advice have no effect on the interactive spec of the=20 > function being advised, and is that really a feature? But perhaps > that's for another thread. Yes.