From: Drew Adams <drew.adams@oracle.com>
To: "Štěpán Němec" <stepnem@gmail.com>, "Lars Ingebrigtsen" <larsi@gnus.org>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
Stefan Monnier <monnier@iro.umontreal.ca>,
17871@debbugs.gnu.org
Subject: bug#17871: 24.4.50; (elisp) `Core Advising Primitives': interactive spec as function?
Date: Sun, 18 Aug 2019 17:35:15 -0700 (PDT) [thread overview]
Message-ID: <d4095afa-4e04-44a3-a224-621d13502536@default> (raw)
In-Reply-To: <877e7a2fut.fsf@gmail.com>
> >> (advice-add 'compose-mail :around #'my-compose-mail-advice)
> >
> > That's a good example. I've now added it to the trunk with some
> > slight modifications.
>
> Thanks (and let me use this opportunity to express sincere admiration
> and gratitude for your general bug slaying performance and stamina).
>
> If that really improves the substance of this bug report only Drew can
> say I guess.
>
> I for one still think that a more detailed explanation similar to
> Michael's from a previous mail[1] would be helpful, ideally with more
> examples.
+1.
The example will help, no doubt. But it would also
help to explicitly point out that this use (for
advice) of `interactive' is not the usual one.
What Michael said here:
Although we can with nadvice use the same syntax
for defining pieces of advice as for defining functions,
advices have a different meaning (semantic). The
interactive specs of advices are not exactly interactive
specs in the common sense - although they look similar,
they are related, but different features.
I think a short example would be good. Also, the term
"function" is a bit unclear here, maybe we should add
"a lambda expression or fbound symbol" or so, to make
clear that we don't mean a sexp that returns a function.
> And although I have managed to clarify a few points myself thanks to
> this conversation, my personal conundrum[2] remains unanswered: why
> does a simple advice have no effect on the interactive spec of the
> function being advised, and is that really a feature? But perhaps
> that's for another thread.
Yes.
next prev parent reply other threads:[~2019-08-19 0:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 14:13 bug#17871: 24.4.50; (elisp) `Core Advising Primitives': interactive spec as function? Drew Adams
2014-06-29 15:01 ` Michael Heerdegen
2014-06-29 15:52 ` Drew Adams
2014-06-29 22:03 ` Stefan Monnier
2014-06-29 23:49 ` Drew Adams
2014-06-30 20:48 ` Michael Heerdegen
2019-08-04 12:06 ` Lars Ingebrigtsen
2019-08-04 12:45 ` Michael Heerdegen
2019-08-04 12:56 ` Lars Ingebrigtsen
2019-08-04 15:15 ` Štěpán Němec
2019-08-05 6:26 ` Michael Heerdegen
2019-08-05 8:44 ` Štěpán Němec
2019-08-05 9:21 ` Lars Ingebrigtsen
2019-08-18 12:26 ` Michael Heerdegen
2019-08-18 13:32 ` Štěpán Němec
2019-08-18 23:06 ` Lars Ingebrigtsen
2019-08-18 23:50 ` Štěpán Němec
2019-08-19 0:35 ` Drew Adams [this message]
2019-08-20 21:49 ` Juri Linkov
2019-08-20 22:44 ` Štěpán Němec
2019-08-21 7:01 ` Stefan Monnier
2019-08-21 8:17 ` Štěpán Němec
2019-08-25 15:51 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4095afa-4e04-44a3-a224-621d13502536@default \
--to=drew.adams@oracle.com \
--cc=17871@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
--cc=stepnem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.