From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.emacs.devel Subject: Re: Should Emacs 26 be portable to Glibc 2.28? Date: Thu, 8 Mar 2018 17:11:58 -0800 Organization: UCLA Computer Science Department Message-ID: References: <96913ef6-44d4-cd63-8a37-5080be2d22dc@cs.ucla.edu> <83bmfyptz2.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1520557818 15721 195.159.176.226 (9 Mar 2018 01:10:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 9 Mar 2018 01:10:18 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Cc: Gnulib bugs , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Fri Mar 09 02:10:14 2018 Return-path: Envelope-to: gnu-bug-gnulib@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eu6Y1-00040U-Bc for gnu-bug-gnulib@m.gmane.org; Fri, 09 Mar 2018 02:10:13 +0100 Original-Received: from localhost ([::1]:42712 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eu6a2-0006eK-Dr for gnu-bug-gnulib@m.gmane.org; Thu, 08 Mar 2018 20:12:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eu6Zn-0006e9-Ug for bug-gnulib@gnu.org; Thu, 08 Mar 2018 20:12:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eu6Zk-0001zh-Qn for bug-gnulib@gnu.org; Thu, 08 Mar 2018 20:12:03 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:60622) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eu6Zk-0001yv-JC; Thu, 08 Mar 2018 20:12:00 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 69FA9160029; Thu, 8 Mar 2018 17:11:59 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id zbsaVgcCdvaA; Thu, 8 Mar 2018 17:11:58 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 73D081615D7; Thu, 8 Mar 2018 17:11:58 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id FQNoeFpO6vG5; Thu, 8 Mar 2018 17:11:58 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 597BF160029; Thu, 8 Mar 2018 17:11:58 -0800 (PST) In-Reply-To: <83bmfyptz2.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Original-Sender: "bug-gnulib" Xref: news.gmane.org gmane.comp.lib.gnulib.bugs:38508 gmane.emacs.devel:223524 Archived-At: On 03/08/2018 05:39 AM, Eli Zaretskii wrote: > -#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */ > +#if defined _IO_ftrylockfile || defined _IO_EOF_SEEN || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */ Thanks, good suggestion, I installed that into Gnulib[1] and copied it into Emacs master[2]. However, after looking into this some more it turns out that we need not backport it to emacs-26. For Emacs built with Glibc, fpending.c is compiled only for glibc 2.1.92 and older, which means that the portability bug with glibc 2.28 cannot be triggered for Emacs. Sorry about the false alarm. [1] https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=74d9d6a293d7462dea8f83e7fc5ac792e956a0ad [2] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f0c590b857415e94a8ed9ded0e9ba2f91ea2a3c7