From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Gnulib bugs <bug-gnulib@gnu.org>, emacs-devel@gnu.org
Subject: Re: Should Emacs 26 be portable to Glibc 2.28?
Date: Thu, 8 Mar 2018 17:11:58 -0800 [thread overview]
Message-ID: <d3bc8950-0072-23a3-bd56-809341ec01c7@cs.ucla.edu> (raw)
In-Reply-To: <83bmfyptz2.fsf@gnu.org>
On 03/08/2018 05:39 AM, Eli Zaretskii wrote:
> -#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
> +#if defined _IO_ftrylockfile || defined _IO_EOF_SEEN || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
Thanks, good suggestion, I installed that into Gnulib[1] and copied it
into Emacs master[2].
However, after looking into this some more it turns out that we need not
backport it to emacs-26. For Emacs built with Glibc, fpending.c is
compiled only for glibc 2.1.92 and older, which means that the
portability bug with glibc 2.28 cannot be triggered for Emacs. Sorry
about the false alarm.
[1]
https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=74d9d6a293d7462dea8f83e7fc5ac792e956a0ad
[2]
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f0c590b857415e94a8ed9ded0e9ba2f91ea2a3c7
prev parent reply other threads:[~2018-03-09 1:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 2:09 Should Emacs 26 be portable to Glibc 2.28? Paul Eggert
2018-03-08 13:39 ` Eli Zaretskii
2018-03-09 1:11 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3bc8950-0072-23a3-bd56-809341ec01c7@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=bug-gnulib@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.