From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#36886: 26.2; (global-eldoc-mode -1) should disable eldoc completely Date: Thu, 1 Aug 2019 16:38:28 +0300 Message-ID: References: <87h8719nzl.fsf@example.com> <87wofx3yls.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="112482"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 Cc: 36886@debbugs.gnu.org To: "Basil L. Contovounesios" , Sanel Zukan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 01 15:39:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htBIg-000T9K-8j for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Aug 2019 15:39:22 +0200 Original-Received: from localhost ([::1]:56020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htBIe-0008Ry-7X for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Aug 2019 09:39:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40065) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htBIO-0008Ro-8w for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 09:39:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1htBIM-0005UZ-J2 for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 09:39:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44901) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1htBIL-0005UG-Vs for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 09:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1htBIL-0003GE-SZ for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 09:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Aug 2019 13:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36886 X-GNU-PR-Package: emacs Original-Received: via spool by 36886-submit@debbugs.gnu.org id=B36886.156466672012499 (code B ref 36886); Thu, 01 Aug 2019 13:39:01 +0000 Original-Received: (at 36886) by debbugs.gnu.org; 1 Aug 2019 13:38:40 +0000 Original-Received: from localhost ([127.0.0.1]:53722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htBHz-0003FX-QF for submit@debbugs.gnu.org; Thu, 01 Aug 2019 09:38:40 -0400 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:46152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htBHx-0003FF-CN for 36886@debbugs.gnu.org; Thu, 01 Aug 2019 09:38:37 -0400 Original-Received: by mail-wr1-f48.google.com with SMTP id z1so73616548wru.13 for <36886@debbugs.gnu.org>; Thu, 01 Aug 2019 06:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sgdppxMpzhc+UvzCrM5OmGabtL+A4nOchWY0YMkDwUk=; b=k+kVLE95thtYnt4iNgOvTYB7SRmz5D+JH1acXgix5y85bcbS9gpbcEKSBRuwFDKgit 5h/GFX7xrvvX3+PnysenMSaWBLnXXWGT5CzTJFcSp00rqAAyfLFlSXUk1m4fZwgK49ew d5P89tCjKzPHBgUCFDQUzzer/3lz8oIK4yHTFTlpCjwCrGdmVXwaxiaPNnXx5IJxKmbO g/V98pTlDSpLLeQd56XMrktZFjtSOdkH0QIVpPMzEAvyn+HVJ8dUjfzVv0tlUS78NThO udDJnVQh2eYHLuaKS6o8rclIfmC9tFXGvqml4fRbgcBZxrMwA753QUNUgoBUmsMNp1TV vgkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sgdppxMpzhc+UvzCrM5OmGabtL+A4nOchWY0YMkDwUk=; b=trM1KSwQBiRDelaVCTpE/QE0kUVeI5vdoEHRbVtJr08gEOJWH6+I+1OmXY13C2gU1x b+zG65nMaRiohyNw03zyTZCWeIt55AMiyWB8FzNXOWhGBOQ0uYfuW1z9N9hZV6z8KWFu NmrjKkzjQ/UqqRRCzt++UXU6FEVPHB4xJ4KZ3hnxH4frYxbz8fF1sCfP0u3o8PsqXZ+D 9a3D3clGla9tg4758z6FnNrb/Owr8gchH06/0uVgzqIuOU150g2mZpZq++CfbmgGcHA8 zpYKrahTA3pdhGa4905KWqX2xtUWloUgx1Xy+iSqWkl1BnlnIUniWMTLj9vOg6CpvUie Dr+w== X-Gm-Message-State: APjAAAV32qr0OuwC9PoIvg6tmBm3nXuk9mVMH3vKHmZWlzZu9yrBWKg3 2+wWykzSyv9lEuVG3R5S6zrNDqMciz4= X-Google-Smtp-Source: APXvYqxiT6VIGRYdwck8UPa0hBf0o1V5aC+xcgSjH6wVK6/kBCz7A0eBzv23T6ZoFKLZpG9VIUrLOQ== X-Received: by 2002:adf:eb4e:: with SMTP id u14mr140737250wrn.168.1564666711177; Thu, 01 Aug 2019 06:38:31 -0700 (PDT) Original-Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id s12sm67127819wmh.34.2019.08.01.06.38.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Aug 2019 06:38:30 -0700 (PDT) In-Reply-To: <87wofx3yls.fsf@tcd.ie> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164227 Archived-At: On 01.08.2019 14:37, Basil L. Contovounesios wrote: > Sanel Zukan writes: > >> When Emacs is run with (global-eldoc-mode -1), eldoc is not completely >> disabled because it will show function arguments inside mode-line. >> >> I believe intention behind (global-eldoc-mode -1) should be that all >> eldoc facility gets disabled. Right now, the only way to stop poping >> stuff in mode-line is this: >> >> (setq-default eldoc-message-function 'ignore) > > CCing Dmitry, who explicitly enabled eldoc-mode in read--expression as > part of bug#27202: https://debbugs.gnu.org/27202. > > My gut says that bug should be fixable within eldoc.el, without having > to tweak read--expression, but I'm not familiar with eldoc. I'm not sure what's the best way. But this should help: diff --git a/lisp/simple.el b/lisp/simple.el index 0bc39f08c0..4eec9e732d 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -1583,7 +1583,8 @@ read--expression ;; FIXME: call emacs-lisp-mode? (add-function :before-until (local 'eldoc-documentation-function) #'elisp-eldoc-documentation-function) - (eldoc-mode 1) + (when global-eldoc-mode + (eldoc-mode 1)) (add-hook 'completion-at-point-functions #'elisp-completion-at-point nil t) (run-hooks 'eval-expression-minibuffer-setup-hook))