From: Dmitry Gutov <dgutov@yandex.ru>
To: "Basil L. Contovounesios" <contovob@tcd.ie>,
Sanel Zukan <sanelz@gmail.com>
Cc: 36886@debbugs.gnu.org
Subject: bug#36886: 26.2; (global-eldoc-mode -1) should disable eldoc completely
Date: Thu, 1 Aug 2019 16:38:28 +0300 [thread overview]
Message-ID: <d3ae521c-185f-455b-30cd-524167685ba2@yandex.ru> (raw)
In-Reply-To: <87wofx3yls.fsf@tcd.ie>
On 01.08.2019 14:37, Basil L. Contovounesios wrote:
> Sanel Zukan <sanelz@gmail.com> writes:
>
>> When Emacs is run with (global-eldoc-mode -1), eldoc is not completely
>> disabled because it will show function arguments inside mode-line.
>>
>> I believe intention behind (global-eldoc-mode -1) should be that all
>> eldoc facility gets disabled. Right now, the only way to stop poping
>> stuff in mode-line is this:
>>
>> (setq-default eldoc-message-function 'ignore)
>
> CCing Dmitry, who explicitly enabled eldoc-mode in read--expression as
> part of bug#27202: https://debbugs.gnu.org/27202.
>
> My gut says that bug should be fixable within eldoc.el, without having
> to tweak read--expression, but I'm not familiar with eldoc.
I'm not sure what's the best way. But this should help:
diff --git a/lisp/simple.el b/lisp/simple.el
index 0bc39f08c0..4eec9e732d 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -1583,7 +1583,8 @@ read--expression
;; FIXME: call emacs-lisp-mode?
(add-function :before-until (local
'eldoc-documentation-function)
#'elisp-eldoc-documentation-function)
- (eldoc-mode 1)
+ (when global-eldoc-mode
+ (eldoc-mode 1))
(add-hook 'completion-at-point-functions
#'elisp-completion-at-point nil t)
(run-hooks 'eval-expression-minibuffer-setup-hook))
next prev parent reply other threads:[~2019-08-01 13:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 10:30 bug#36886: 26.2; (global-eldoc-mode -1) should disable eldoc completely Sanel Zukan
2019-08-01 11:37 ` Basil L. Contovounesios
2019-08-01 12:29 ` Sanel Zukan
2019-08-01 13:38 ` Dmitry Gutov [this message]
2019-08-02 6:35 ` Eli Zaretskii
2019-08-02 9:35 ` Sanel Zukan
2019-08-02 11:44 ` Basil L. Contovounesios
2019-08-02 12:00 ` Eli Zaretskii
2019-08-02 13:19 ` Basil L. Contovounesios
2019-08-02 14:28 ` Eli Zaretskii
2019-08-04 0:35 ` Noam Postavsky
2019-08-04 7:51 ` Basil L. Contovounesios
2019-08-04 9:00 ` Štěpán Němec
2019-08-04 14:34 ` Noam Postavsky
2019-08-15 0:58 ` Noam Postavsky
2019-08-15 8:31 ` Štěpán Němec
2019-08-21 0:24 ` Noam Postavsky
2019-08-04 16:27 ` Eli Zaretskii
2019-08-02 12:36 ` Sanel Zukan
2019-08-02 11:50 ` Eli Zaretskii
2019-08-02 12:51 ` Sanel Zukan
2019-08-02 14:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3ae521c-185f-455b-30cd-524167685ba2@yandex.ru \
--to=dgutov@yandex.ru \
--cc=36886@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=sanelz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.