From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#67417: 29.1.50; c-ts-mode syntax issues with no brackets Date: Mon, 11 Dec 2023 02:29:47 +0200 Message-ID: References: <83h6lbfwcu.fsf@gnu.org> <2ba91823-bf3c-4d5d-e556-1622135ab2fd@gutov.dev> <8f8aa9c5-95cb-44e5-b41e-4cf58f024624@gmail.com> <33b587b2-1ea1-f756-704f-e75a3193c147@gutov.dev> <720463fd-c6d8-4c31-8240-7017984084a4@gmail.com> <0dd74b5b-e1d2-462b-bbc3-01d0e4d71713@gmail.com> <83plzfye5e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3128"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 67417-done@debbugs.gnu.org, arteen@linux.ucla.edu To: Yuan Fu , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 11 01:31:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rCUCT-0000cf-Kd for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Dec 2023 01:31:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCUC9-0002s6-VP; Sun, 10 Dec 2023 19:30:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCUC8-0002q8-Jm for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 19:30:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCUC8-00076s-Bd for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 19:30:48 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCUCM-0002je-E8 for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 19:31:02 -0500 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2023 00:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 67417 X-GNU-PR-Package: emacs Mail-Followup-To: 67417@debbugs.gnu.org, dmitry@gutov.dev, arteen@linux.ucla.edu Original-Received: via spool by 67417-done@debbugs.gnu.org id=D67417.170225461710442 (code D ref 67417); Mon, 11 Dec 2023 00:31:02 +0000 Original-Received: (at 67417-done) by debbugs.gnu.org; 11 Dec 2023 00:30:17 +0000 Original-Received: from localhost ([127.0.0.1]:52121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCUBc-0002iM-SI for submit@debbugs.gnu.org; Sun, 10 Dec 2023 19:30:17 -0500 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:48927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCUBa-0002i4-M2 for 67417-done@debbugs.gnu.org; Sun, 10 Dec 2023 19:30:15 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 0A0263200A89; Sun, 10 Dec 2023 19:29:52 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 10 Dec 2023 19:29:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1702254592; x=1702340992; bh=Rv85m/MuBhXUql/Lb1WF3P5sxcp+NlvfwQ3 z++BVSAg=; b=NOouN1FNoxfBVhQP7/jpSL/LALTTc0UwHg5q4639yqKOcEBODE/ 6E12Ti6fu3lssY8O/xyeSXHYtUQaSHjjwzZZ4OYImwsGZ29YXopev7rito4mgvBQ jyneTzXFIPom9mGYvgHLNU7t/2Ms2mzvboAIeeuD/t2duTg9Y3Y14JXzZS0PJi35 HZiWRsz4xt6+5u/bfNbTZ1hnxLELg25ReyPF6IvXAclZ5DxfmMdz8Qi//4uz/XOF 40ekJ6rYC9UdboeLnGsRkw5hloEw9icx9fForW2wtcwbZLfrNAlkcMWV5npQA8zt zNx/RN6GMyr15VeaK7n0XgWKoS4zqa1gvPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1702254592; x=1702340992; bh=Rv85m/MuBhXUql/Lb1WF3P5sxcp+NlvfwQ3 z++BVSAg=; b=Uf4cC5AcEw+d3Gs2c6gAxCuR+V3wmaWoj0RkOaZSrWGnXiNomZc Fm1XaWF0IJM04iu/gpdD8C5fvjXLRxfSRqJvb1ZAzHDHEWnTULNiJVU3JtMpyGit ExAyEUBEtNpGkjPyFQcTQFz8Ugn+3Ie+id8PmsFGag5QJJjUWvrciKlepzXHzx6K gXZotzRuiHslU6udbugENNqxVKmaAuCi9Cg+bCVDLihjnJMxedhSuqIyWCeubF+Z 2Fz2gP/tDlRgfJABRhZg1LcF+92G73XKZLcrRLN4j5oDL7FNlxIQNL0VtJFFZ6nO 23DR8sxhD9TWZALUeoq8MhCLlx5yj3vkwlg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeluddgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Dec 2023 19:29:50 -0500 (EST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275951 Archived-At: Version: 29.2 On 10/12/2023 11:29, Yuan Fu wrote: > > > On 12/9/23 12:27 AM, Eli Zaretskii wrote: >>> Date: Thu, 30 Nov 2023 23:58:14 -0800 >>> Cc: 67417@debbugs.gnu.org >>> From: Yuan Fu >>> >>>> The rest of the nodes (if/while/do/for) don't result in parse errors >>>> here, as long as the condition in parentheses is typed out correctly. >>>> >>>> I tried some additional clauses looking for "previous sibling", >>>> checking whether it's for_statement, etc, which ends with "expression >>>> statement", and that one is empty... but it a fair amount of code >>>> which will likely miss other edge cases anyway. Or breaks when the >>>> grammar changes. >>> Yeah, for now we can match for the specific case where there's an else >>> before a "}". That should reduce the chance of it matching other edge >>> cases. I'll give it another look on this weekend. >> Any progress here? > I pushed a commit that changes the too-board heuristic to only match > "else before closing bracket". Hopefully this won't cause any false > matches. > > I think we can close this. Dmitry, WDYT? LGTM! (And closing.) Arteen, let us know if you see any problems with the fixes that are now in the emacs-29 branch.