From: Ken Brown <kbrown@cornell.edu>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: "36405@debbugs.gnu.org" <36405@debbugs.gnu.org>
Subject: bug#36405: 26.2.90; O_PATH problem on some versions of Cygwin
Date: Fri, 28 Jun 2019 17:57:04 +0000 [thread overview]
Message-ID: <d31e11b8-5954-7371-f2e5-899bbac2e2f6@cornell.edu> (raw)
In-Reply-To: <d8ae5b11-73cf-74c0-6f06-a772eccfa2aa@cs.ucla.edu>
On 6/27/2019 4:47 PM, Paul Eggert wrote:
> --- a/src/fileio.c
> +++ b/src/fileio.c
> @@ -61,6 +61,10 @@ Copyright (C) 1985-1988, 1993-2019 Free Software Foundation, Inc.
> # include <linux/fs.h>
> #endif
>
> +#ifdef __CYGWIN__
> +# undef O_PATH /* Buggy in Cygwin 3.0.0 through 3.0.7. */
> +#endif
This hunk is not necessary. The only use of O_PATH in fileio.c is coupled with
O_DIRECTORY, and this is not affected by the bug.
But, in any case, I agree with Eli's point that your patch is too drastic. I
don't see how my patch is intrusive.
Ken
next prev parent reply other threads:[~2019-06-28 17:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 19:28 bug#36405: 26.2.90; O_PATH problem on some versions of Cygwin Ken Brown
2019-06-27 20:47 ` Paul Eggert
2019-06-28 6:25 ` Eli Zaretskii
2019-06-29 6:26 ` Paul Eggert
2019-06-29 7:06 ` Eli Zaretskii
2019-06-29 18:03 ` Ken Brown
2019-06-29 18:19 ` Eli Zaretskii
2019-06-28 17:57 ` Ken Brown [this message]
2019-06-29 6:20 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d31e11b8-5954-7371-f2e5-899bbac2e2f6@cornell.edu \
--to=kbrown@cornell.edu \
--cc=36405@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.